Skip to content

Conversation

@gonzalad
Copy link
Contributor

This little PR fixes typescript angular integration test and reactivates them.

The expected files where not the correct ones.

Asking for review:
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10)

Thanks,

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

The expected files where not the correct ones.
@wing328
Copy link
Member

wing328 commented Nov 29, 2025

thanks for the PR

let's give it a try

@wing328 wing328 merged commit 7a48bd8 into OpenAPITools:master Nov 29, 2025
14 checks passed
@gonzalad gonzalad deleted the tests/fix-typescript-tests branch November 30, 2025 12:28
@wing328
Copy link
Member

wing328 commented Dec 4, 2025

The expected files where not the correct ones.

@gonzalad thanks again for the PR

Do you mind sharing the exact commands to update these files so that we can reuse moving forward?

@gonzalad
Copy link
Contributor Author

gonzalad commented Dec 4, 2025

@wing328 alas, I didn't use any commands for that, I simply checked that the files in the target/-results folder where good one and copied the manually to src/test/resources//expected folder.

The fundamental approach of those integration tests is brittle, but I don't see how to fix that.
Perhaps providing a script or a snapshot-record parameter to update automatically the src/test/resources/* from target/*-results ?

@wing328
Copy link
Member

wing328 commented Dec 4, 2025

thanks for sharing more.

i think what i'll do is to replace these tests with something else that can be more easily understood by developers on what's wrong or what's changed.

@wing328
Copy link
Member

wing328 commented Dec 7, 2025

fyi .merged #22501 to disable the tests as it's causing false alarms in the master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants