Skip to content

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Dec 1, 2025

based on #22458

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

artnan and others added 3 commits November 28, 2025 14:13
  Header parameters defined in OpenAPI specs were being accepted as method
  parameters but never actually added to the HTTP request.

  Fixes #22457
@wing328 wing328 changed the title [Java] Header parameters (in: header) are accepted as method parameters in the generated google-api-client Java client but are never added to the HTTP request [Java] fix missing header parameters in the generated google-api-client Java client Dec 1, 2025
@wing328 wing328 added this to the 7.18.0 milestone Dec 1, 2025
@wing328 wing328 marked this pull request as ready for review December 1, 2025 05:09
@wing328 wing328 merged commit c0d9886 into master Dec 1, 2025
149 checks passed
@wing328 wing328 deleted the artnan-fix/google-api-client-header-params branch December 1, 2025 05:09
String key = entry.getKey();
Object value = entry.getValue();
// Check if this is a header parameter by name
if ("uuid_test".equals(key) && value != null) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artnan

thanks again for the contribution.

instead of looping through all header parameters, what about checking if params contains the key uuid_test for example and update httpRequest accordingly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants