Skip to content

Conversation

@dsteeley
Copy link
Contributor

@dsteeley dsteeley commented Dec 1, 2025

Fix bug in rust-server where it was attempting to convert bytes to string and failing on invalid UTF-8 format. Fixed this up in multiple locations and the multipart support.

Error hit - Error converting octet stream to string: FromUtf8Error { bytes: [...], error: Utf8Error { valid_up_to: 1, error_len: Some(1) }
Endpoint this was hit on

     content:
        application/gzip:
          schema:
            type: string
            format: binary

Resolve by directly returning the bytes rather than attempting string conversion.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@dsteeley dsteeley force-pushed the hyper1_binary_decode branch from 881b2f7 to 5c359a1 Compare December 1, 2025 11:19
@wing328
Copy link
Member

wing328 commented Dec 1, 2025

circleci failure not related to this pr

@wing328 wing328 merged commit 41f97d8 into OpenAPITools:master Dec 1, 2025
17 of 18 checks passed
@wing328 wing328 added this to the 7.18.0 milestone Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants