Skip to content

Conversation

@berk-dilek
Copy link

@berk-dilek berk-dilek commented Jan 5, 2026

Potentially fixes - #22624
When a property has 'type: number' without an explicit format, the generated enum incorrectly conformed to ParameterConvertible. This caused compilation errors because the enum already gets the asParameter method via the RawRepresentable extension in Extensions.swift.

The issue occurred because the template only checked isDouble (which requires 'format: double') but not isNumeric (which is set for all number types).

Added {{^isNumeric}} check to prevent ParameterConvertible conformance for all numeric enum types, not just those with explicit format.

Affected templates:

  • modelEnum.mustache
  • modelInlineEnumDeclaration.mustache

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Prevent incorrect ParameterConvertible conformance for Swift 6 numeric enums, fixing compile errors from duplicate asParameter implementations.

  • Bug Fixes
    • Added {{^isNumeric}} guard so numeric enums (type: number) don't conform to ParameterConvertible.
    • Covers all number types, not just double (previously only checked isDouble).
    • Updated modelEnum.mustache and modelInlineEnumDeclaration.mustache.

Written for commit fa30fa5. Summary will update on new commits.

When a property has 'type: number' without an explicit format, the
generated enum incorrectly conformed to ParameterConvertible. This
caused compilation errors because the enum already gets the asParameter
method via the RawRepresentable extension in Extensions.swift.

The issue occurred because the template only checked isDouble (which
requires 'format: double') but not isNumeric (which is set for all
number types).

Added {{^isNumeric}} check to prevent ParameterConvertible conformance
for all numeric enum types, not just those with explicit format.

Affected templates:
- modelEnum.mustache
- modelInlineEnumDeclaration.mustache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant