[Swift6] Fix incorrect ParameterConvertible conformance for number enums #22622
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fixes - #22624
When a property has 'type: number' without an explicit format, the generated enum incorrectly conformed to ParameterConvertible. This caused compilation errors because the enum already gets the asParameter method via the RawRepresentable extension in Extensions.swift.
The issue occurred because the template only checked isDouble (which requires 'format: double') but not isNumeric (which is set for all number types).
Added {{^isNumeric}} check to prevent ParameterConvertible conformance for all numeric enum types, not just those with explicit format.
Affected templates:
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Prevent incorrect ParameterConvertible conformance for Swift 6 numeric enums, fixing compile errors from duplicate asParameter implementations.
Written for commit fa30fa5. Summary will update on new commits.