Skip to content

[Core] Fix isDouble flag not being set for 'type: number' without format #22623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
berk-dilek wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[Core] Fix isDouble flag not being set for 'type: number' without format #22623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3002,7 +3002,9 @@ protected void updateModelForNumber(CodegenModel model, Schema schema) {
model.isNumeric = Boolean.TRUE;
if (ModelUtils.isFloatSchema(schema)) { // float
model.isFloat = Boolean.TRUE;
} else if (ModelUtils.isDoubleSchema(schema)) { // double
} else {
// Set isDouble for explicit "format: double" OR when no format is specified
// (since "type: number" without format defaults to Double in most languages)
model.isDouble = Boolean.TRUE;
}
}
Expand Down Expand Up @@ -3886,7 +3888,9 @@ protected void updatePropertyForNumber(CodegenProperty property, Schema p) {
property.isNumeric = Boolean.TRUE;
if (ModelUtils.isFloatSchema(p)) { // float
property.isFloat = Boolean.TRUE;
} else if (ModelUtils.isDoubleSchema(p)) { // double
} else {
// Set isDouble for explicit "format: double" OR when no format is specified
// (since "type: number" without format defaults to Double in most languages)
property.isDouble = Boolean.TRUE;
}
}
Expand Down