-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
feat(typescript-angular): add angular 21 support #22636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sergejomon
wants to merge
1
commit into
OpenAPITools:master
Choose a base branch
from
sergejomon:feat/typescript-angular-21
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+25,032
−4
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| generatorName: typescript-angular | ||
| outputDir: samples/client/petstore/typescript-angular-v21-provided-in-root/builds/default | ||
| inputSpec: modules/openapi-generator/src/test/resources/3_0/petstore.yaml | ||
| templateDir: modules/openapi-generator/src/main/resources/typescript-angular | ||
| additionalProperties: | ||
| ngVersion: 21.0.0 | ||
| supportsES6: true | ||
| enumNameMappings: | ||
| delivered: SHIPPED |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| generatorName: typescript-angular | ||
| outputDir: samples/client/petstore/typescript-angular-v21/builds/default | ||
| inputSpec: modules/openapi-generator/src/test/resources/3_0/petstore.yaml | ||
| templateDir: modules/openapi-generator/src/main/resources/typescript-angular | ||
| additionalProperties: | ||
| ngVersion: 21.0.0 | ||
| npmName: sample-angular-21-0-0 | ||
| supportsES6: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
...openapi-generator/src/main/resources/typescript-angular/angularDependenciesByVersion.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
115 changes: 115 additions & 0 deletions
115
samples/client/petstore/typescript-angular-v21-provided-in-root/angular.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| { | ||
| "$schema": "./node_modules/@angular/cli/lib/config/schema.json", | ||
| "version": 1, | ||
| "newProjectRoot": "tests", | ||
| "projects": { | ||
| "test-default": { | ||
| "root": "tests/default", | ||
| "sourceRoot": "tests/default/src", | ||
| "projectType": "application", | ||
| "prefix": "app", | ||
| "schematics": {}, | ||
| "architect": { | ||
| "build": { | ||
| "builder": "@angular-devkit/build-angular:application", | ||
| "options": { | ||
| "aot": true, | ||
| "outputPath": { | ||
| "base": "tests/default/dist" | ||
| }, | ||
| "index": "tests/default/src/index.html", | ||
| "polyfills": [ | ||
| "tests/default/src/polyfills.ts" | ||
| ], | ||
| "tsConfig": "tests/default/src/tsconfig.app.json", | ||
| "assets": [ | ||
| "tests/default/src/favicon.ico", | ||
| "tests/default/src/assets" | ||
| ], | ||
| "styles": [ | ||
| "tests/default/src/styles.css" | ||
| ], | ||
| "scripts": [], | ||
| "browser": "tests/default/src/main.ts" | ||
| }, | ||
| "configurations": { | ||
| "production": { | ||
| "budgets": [ | ||
| { | ||
| "type": "anyComponentStyle", | ||
| "maximumWarning": "6kb" | ||
| } | ||
| ], | ||
| "fileReplacements": [ | ||
| { | ||
| "replace": "tests/default/src/environments/environment.ts", | ||
| "with": "tests/default/src/environments/environment.prod.ts" | ||
| } | ||
| ], | ||
| "optimization": true, | ||
| "outputHashing": "all", | ||
| "sourceMap": false, | ||
| "namedChunks": false, | ||
| "aot": true, | ||
| "extractLicenses": true | ||
| }, | ||
| "development": {} | ||
| }, | ||
| "defaultConfiguration": "production" | ||
| }, | ||
| "serve": { | ||
| "builder": "@angular-devkit/build-angular:dev-server", | ||
| "options": { | ||
| }, | ||
| "configurations": { | ||
| "production": { | ||
| "browserTarget": "test-default:build:production" | ||
| }, | ||
| "development": { | ||
| "browserTarget": "test-default:build:development" | ||
| } | ||
| }, | ||
| "defaultConfiguration": "development" | ||
| }, | ||
| "extract-i18n": { | ||
| "builder": "@angular-devkit/build-angular:extract-i18n", | ||
| "options": { | ||
| "browserTarget": "test-default:build" | ||
| } | ||
| }, | ||
| "test": { | ||
| "builder": "@angular-devkit/build-angular:karma", | ||
| "options": { | ||
| "main": "tests/default/src/test.ts", | ||
| "polyfills": "tests/default/src/polyfills.ts", | ||
| "tsConfig": "tests/default/src/tsconfig.spec.json", | ||
| "karmaConfig": "tests/default/src/karma.conf.js", | ||
| "styles": [ | ||
| "tests/default/src/styles.css" | ||
| ], | ||
| "scripts": [], | ||
| "assets": [ | ||
| "tests/default/src/favicon.ico", | ||
| "tests/default/src/assets" | ||
| ] | ||
| } | ||
| }, | ||
| "lint": { | ||
| "builder": "@angular-devkit/build-angular:tslint", | ||
| "options": { | ||
| "tsConfig": [ | ||
| "tests/default/src/tsconfig.app.json", | ||
| "tests/default/src/tsconfig.spec.json" | ||
| ], | ||
| "exclude": [ | ||
| "**/node_modules/**" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "cli": { | ||
| "analytics": false | ||
| } | ||
| } |
4 changes: 4 additions & 0 deletions
4
samples/client/petstore/typescript-angular-v21-provided-in-root/builds/default/.gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| wwwroot/*.js | ||
| node_modules | ||
| typings | ||
| dist |
23 changes: 23 additions & 0 deletions
23
...petstore/typescript-angular-v21-provided-in-root/builds/default/.openapi-generator-ignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # OpenAPI Generator Ignore | ||
| # Generated by openapi-generator https://github.com/openapitools/openapi-generator | ||
|
|
||
| # Use this file to prevent files from being overwritten by the generator. | ||
| # The patterns follow closely to .gitignore or .dockerignore. | ||
|
|
||
| # As an example, the C# client generator defines ApiClient.cs. | ||
| # You can make changes and tell OpenAPI Generator to ignore just this file by uncommenting the following line: | ||
| #ApiClient.cs | ||
|
|
||
| # You can match any string of characters against a directory, file or extension with a single asterisk (*): | ||
| #foo/*/qux | ||
| # The above matches foo/bar/qux and foo/baz/qux, but not foo/bar/baz/qux | ||
|
|
||
| # You can recursively match patterns against a directory, file or extension with a double asterisk (**): | ||
| #foo/**/qux | ||
| # This matches foo/bar/qux, foo/baz/qux, and foo/bar/baz/qux | ||
|
|
||
| # You can also negate patterns with an exclamation (!). | ||
| # For example, you can ignore all files in a docs folder with the file extension .md: | ||
| #docs/*.md | ||
| # Then explicitly reverse the ignore rule for a single file: | ||
| #!docs/README.md |
23 changes: 23 additions & 0 deletions
23
.../petstore/typescript-angular-v21-provided-in-root/builds/default/.openapi-generator/FILES
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| .gitignore | ||
| README.md | ||
| api.base.service.ts | ||
| api.module.ts | ||
| api/api.ts | ||
| api/pet.service.ts | ||
| api/store.service.ts | ||
| api/user.service.ts | ||
| configuration.ts | ||
| encoder.ts | ||
| git_push.sh | ||
| index.ts | ||
| model/apiResponse.ts | ||
| model/category.ts | ||
| model/models.ts | ||
| model/order.ts | ||
| model/pet.ts | ||
| model/tag.ts | ||
| model/user.ts | ||
| param.ts | ||
| provide-api.ts | ||
| query.params.ts | ||
| variables.ts |
1 change: 1 addition & 0 deletions
1
...etstore/typescript-angular-v21-provided-in-root/builds/default/.openapi-generator/VERSION
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 7.19.0-SNAPSHOT |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR
can you please create a new yaml in bin/configs based on https://github.com/OpenAPITools/openapi-generator/blob/master/bin/configs/typescript-angular-v20-provided-in-root.yaml ?
then update the workflow https://github.com/OpenAPITools/openapi-generator/blob/master/.github/workflows/samples-typescript-client.yaml with the new sample folder.
please also copy the tests from samples/client/petstore/typescript-angular-v20-provided-in-root/ into the new folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done !