[typescript-axios] Handle sets as arrays in input parameters #22642
+193
−65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an array is defined as having unique items, the generated Typescript model makes it a set instead of an array. However, this is an iterator instead of a concrete object. When passed to a JSON serializer, it results in the set being serialized as an empty object.
This PR changes the Axios templates to add a replacer function to
JSON.stringifycalls which turns any set into an array before serialization. Iterating over query parameters has also been changed to do so recursively if a parameter is either an array or a set.Fixes #21663
@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka @joscha
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Ensure Sets generated for uniqueItems are serialized as arrays across the TypeScript Axios client to prevent empty-object payloads and broken headers/query params. Fixes #21663.
Written for commit 5256bcb. Summary will update on new commits.