Skip to content

Conversation

@rgroothuijsen
Copy link
Contributor

@rgroothuijsen rgroothuijsen commented Jan 9, 2026

When an array is defined as having unique items, the generated Typescript model makes it a set instead of an array. However, this is an iterator instead of a concrete object. When passed to a JSON serializer, it results in the set being serialized as an empty object.

This PR changes the Axios templates to add a replacer function to JSON.stringify calls which turns any set into an array before serialization. Iterating over query parameters has also been changed to do so recursively if a parameter is either an array or a set.

Fixes #21663

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka @joscha

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Ensure Sets generated for uniqueItems are serialized as arrays across the TypeScript Axios client to prevent empty-object payloads and broken headers/query params. Fixes #21663.

  • Bug Fixes
    • Added replaceWithSerializableTypeIfNeeded and used it as a JSON.stringify replacer to serialize Set as Array.
    • Treated Set like Array in setFlattenedQueryParams for recursive query param handling.
    • Applied replacer in form-data Blobs and header serialization paths.
    • Updated imports/templates and regenerated samples.

Written for commit 5256bcb. Summary will update on new commits.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 31 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][TYPESCRIPT-AXIOS] Fields with uniqueItems: true generate Set<T>, but Set is serialized incorrectly (empty object)

1 participant