Skip to content

Conversation

@JulianVennen
Copy link
Contributor

@JulianVennen JulianVennen commented Jan 9, 2026

This is kind of a follow-up to #22310. There was a bunch of cases where only required was checked when determining nullability in PHPDoc. I have converted these to notRequiredOrIsNullable.
php-nextgen also now uses exts instead of vendorExtensions.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Correctly mark nullable params and properties as nullable in generated PHPDoc for PHP and php-nextgen clients, improving type clarity. Also switch php-nextgen templates from vendorExtensions to exts.

  • Bug Fixes

    • Use notRequiredOrIsNullable to add |null in PHPDoc for params and model properties.
    • Update samples (e.g., SplFileObject|null for binary body).
  • Refactors

    • Replace vendorExtensions.* with exts.* across php-nextgen templates (api, docs, tests, models).
    • Align return/param types and test operation IDs to exts keys.

Written for commit ab7b185. Summary will update on new commits.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant