Skip to content

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Jan 14, 2026

based on #22588

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Add Kotlin Spring 3 RestClient integration tests to verify query parameter serialization for single values and lists, preventing regressions. Also updates the Gradle template and samples to include Spring Boot test support and minor build config fixes.

  • New Features

    • Added PetApiTest and UserApiTest to assert correct query param encoding (e.g., status=pending,available and username/password).
    • Registered new test files in test_file_list.yaml.
  • Dependencies

    • Added testImplementation "org.springframework.boot:spring-boot-test" to Kotlin Spring client projects (spring-2 webclient, spring-3 webclient/restclient).
    • Moved kotlintest test dependency to the common test block in the Kotlin client template.
    • Gated jvmToolchain(17) under useSpringBoot3 for the spring-webclient template and cleaned up sample build.gradle files.

Written for commit e8c422a. Summary will update on new commits.

@wing328 wing328 changed the title Pkubowicz kotlin params integ test [kotlin] Add integration test for query params Jan 14, 2026
@wing328 wing328 marked this pull request as ready for review January 14, 2026 07:26
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 53 files

@wing328 wing328 added this to the 7.19.0 milestone Jan 14, 2026
@wing328 wing328 merged commit b1b556a into master Jan 14, 2026
66 checks passed
@wing328 wing328 deleted the pkubowicz-kotlin-params-integ-test branch January 14, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants