refactor: Introduce AgentExecutor for core loop orchestration #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
abrichr
commented
Apr 5, 2025
abrichr
commented
- Extracts the core perceive-plan-act loop from the deprecated demo.py into a reusable AgentExecutor class in omnimcp/agent_executor.py.
- Introduces cli.py as the new primary command-line entry point using python-fire.
- Adds unit tests for AgentExecutor using pytest and mocks.
- Removes the platform parameter from core.plan_action_for_ui, simplifying the planner interface.
- Updates README.md to reflect the new architecture, cli usage, and roadmap.
- Adds pyobjc-framework-Cocoa as a conditional dependency for macOS in pyproject.toml.
- Removes the deprecated demo.py script.
- Extracts the core perceive-plan-act loop from the deprecated demo.py into a reusable AgentExecutor class in omnimcp/agent_executor.py. - Introduces cli.py as the new primary command-line entry point using python-fire. - Adds unit tests for AgentExecutor using pytest and mocks. - Removes the platform parameter from core.plan_action_for_ui, simplifying the planner interface. - Updates README.md to reflect the new architecture, cli usage, and roadmap. - Adds pyobjc-framework-Cocoa as a conditional dependency for macOS in pyproject.toml. - Removes the deprecated demo.py script.
Mocks the take_screenshot call within AgentExecutor tests to prevent failures in headless CI environments due to missing $DISPLAY.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.