Skip to content

Conversation

@ClutchplateDude
Copy link
Member

A new define (TEST_VERIFY_MODE) can be used to make the mount write menus to the terminal (serial port) and await commands from it (numeric keys).
Basic commands like moving RA/DEC/ALT/AZ, connecting to drivers, listing hardware, etc. are implemented.

@ClutchplateDude ClutchplateDude requested review from andre-stefanov and julianneswinoga and removed request for julianneswinoga January 30, 2025 08:08
@openastrotech-bot
Copy link
Contributor

Looks like your PR has code that needs to be changed in order to meet our coding standards!
Here are your options:

  1. Apply the patch that was generated by the job
    1. Click details under the failing clang-format check
    2. Click the Artifacts dropdown in the top right
    3. Download + unzip the clang-format-diff.patch file into the OpenAstroTracker-Firmware repo
    4. Run git apply clang-format-diff.patch to make the changes
    5. Commit and push up the formatted code
  2. Run clang-format locally
    1. Run the command bash -c 'shopt -s nullglob globstar;GLOBIGNORE=./src/libs/TimerInterrupt/*; for i in ./{.,src/**,unit_tests,boards/**}/*.{c,cpp,h,hpp}; do clang-format -i $i; done'
    2. Commit and push up the formatted code

Copy link
Member

@julianneswinoga julianneswinoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add in TEST_VERIFY_MODE to matrix_build.py because right now this code isn't being checked by CI. I think you also should change all the checks to #if (vs #ifdef) so that #define TEST_VERIFY_MODE 1 enables it. That'll make it easier to use with matrix_build.py

julianneswinoga
julianneswinoga previously approved these changes Feb 8, 2025
@julianneswinoga
Copy link
Member

Just make sure you squash and merge!

@ClutchplateDude ClutchplateDude merged commit 03af68a into develop Feb 9, 2025
8 checks passed
@ClutchplateDude ClutchplateDude deleted the test-terminal branch February 9, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants