feat: added metrics for P99 and slow command statistics #3071

Mixficsol · 2025-04-01T07:52:36Z

P99 命令的统计，每分钟会重置一次

127.0.0.1:9221> info commandp99
# Commands P99
Command: set
TP99 ms: 0.50
TP999 ms: 0.50
TP9999 ms: 0.50
----------------------
Command: config
TP99 ms: 0.50
TP999 ms: 0.50
TP9999 ms: 0.50
----------------------

Slow 慢命令统计, 每分钟会重置一次

127.0.0.1:9221> info slowcommand
# SlowCommand Count
info:slow_count=229
hset:slow_count=72866
config:slow_count=186

coderabbitai · 2025-04-01T07:52:43Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

YuCai18 · 2025-07-14T08:30:51Z

tools/pika_exporter/exporter/metrics/commandp99.go

+    "command_p99_info": {
+        Parser: &regexParser{
+            name: "command_p99_info",
+            reg: regexp.MustCompile(`Command:\s*(?P<cmd>\S+)\s*\r?\n(?:.*\r?\n)*?TP99 ms:\s*(?P<tp99>[\d.]+)\s*\r?\n.*?TP999 ms:\s*(?P<tp999>[\d.]+)\s*\r?\n.*?TP9999 ms:\s*(?P<tp9999>[\d.]+)`),


多层嵌套匹配效率低，建议改为更简单的非贪婪匹配：Command:\s*(?P<cmd>\S+)[\s\S]*?TP99 ms:\s*(?P<tp99>[\d.]+)[\s\S]*?TP999 ms:\s*(?P<tp999>[\d.]+)[\s\S]*?TP9999 ms:\s*(?P<tp9999>[\d.]+)

YuCai18 · 2025-07-14T08:48:51Z

tools/pika_exporter/exporter/metrics/slowcommand.go

+    "slow_command_info": {
+        Parser: &regexParser{
+            name: "slow_command_info",
+            reg: regexp.MustCompile(`(?P<cmd>\S+):slow_count=(?P<slow_count>\d+)`),


写法\S+ 会去匹配任意非空白字符（包括冒号 :），建议改为[^\s:]+

YuCai18 · 2025-07-14T09:07:40Z

src/pika_admin.cc

+      } else {
+        tmp_stream << "Command: " << command_name << "\r\n";
+      }
+


对于P99理论上至少需要100个样本才有意义。建议增加一个判断，若total_count < 100就continue。

github-actions bot added the ✏️ Feature New feature or request label Apr 1, 2025

Mixficsol force-pushed the feature/add_p99 branch 6 times, most recently from 629ecc0 to 99e4623 Compare April 1, 2025 11:22

wuxianrong added 2 commits April 2, 2025 20:31

added metrics for P99 and slow command statistics

89460cb

The Copy on Write mode is used

1f046c4

Mixficsol force-pushed the feature/add_p99 branch from 99e4623 to 1f046c4 Compare April 2, 2025 12:32

Mixficsol added the 3.5.5 label Apr 2, 2025

Mixficsol marked this pull request as ready for review April 3, 2025 02:03

Mixficsol requested review from baixin01 and wangshao1 April 3, 2025 08:28

YuCai18 mentioned this pull request Jul 9, 2025

fix:Fixed some potential bugs for P99 and slow command statistics #3121

Closed

YuCai18 reviewed Jul 14, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: added metrics for P99 and slow command statistics #3071

feat: added metrics for P99 and slow command statistics #3071

Uh oh!

Mixficsol commented Apr 1, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Apr 1, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

YuCai18 Jul 14, 2025

Uh oh!

YuCai18 Jul 14, 2025

Uh oh!

YuCai18 Jul 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat: added metrics for P99 and slow command statistics #3071

Are you sure you want to change the base?

feat: added metrics for P99 and slow command statistics #3071

Uh oh!

Conversation

Mixficsol commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

YuCai18 Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

YuCai18 Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

YuCai18 Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Mixficsol commented Apr 1, 2025 •

edited

Loading

coderabbitai bot commented Apr 1, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)