-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat:Fix strong consistency TODOs #3120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Fix strong consistency TODOs #3120
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
a88f40c to
0fa7b62
Compare
ea7c8ec to
b44ce50
Compare
b44ce50 to
854eebf
Compare
| task->total_tasks = argvs.size(); | ||
| task->resps.resize(argvs.size()); | ||
|
|
||
| for (size_t i = 0; i < argvs.size(); ++i) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你目前压测的方式,这里的argvs都是一个,只有客户端使用pipeline方式的时候才会大于1.
另外,如果是pipeline的方式压测,你这里的逻辑是把这些命令执行又拆分到同一个线程池,线程池都占满的时候,会不会导致hang住?
修复TODOs的bug #3112