-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: import braft #3182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.5
Are you sure you want to change the base?
feat: import braft #3182
Changes from all commits
720c150
7ad42a2
d93216f
66b19c7
0a646cb
e75170f
3e973c3
f55b36d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -200,6 +200,7 @@ ExternalProject_Add(gflags | |||||
| -DGFLAGS_NAMESPACE=gflags | ||||||
| -DBUILD_STATIC_LIBS=ON | ||||||
| -DBUILD_SHARED_LIBS=OFF | ||||||
| -DREGISTER_INSTALL_PREFIX=OFF | ||||||
| BUILD_COMMAND | ||||||
| make -j${CPU_CORE} | ||||||
| ) | ||||||
|
|
@@ -273,10 +274,10 @@ ExternalProject_Add(glog | |||||
| -DCMAKE_POLICY_VERSION_MINIMUM=3.5 | ||||||
| -DCMAKE_INSTALL_PREFIX=${STAGED_INSTALL_PREFIX} | ||||||
| -DCMAKE_BUILD_TYPE=${LIB_BUILD_TYPE} | ||||||
| -DWITH_GFLAGS=ON | ||||||
| -DWITH_GFLAGS=OFF | ||||||
| -DBUILD_TESTING=OFF | ||||||
| -DBUILD_SHARED_LIBS=OFF | ||||||
| -DWITH_UNWIND=${LIBUNWIND_ON} | ||||||
| -DWITH_UNWIND=OFF | ||||||
|
||||||
| -DWITH_UNWIND=OFF | |
| -DWITH_UNWIND=ON |
Copilot
AI
Oct 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The zlib version is being upgraded from 1.2.13 to 1.3.1. While version upgrades are generally good, ensure this has been tested thoroughly as zlib is a critical compression library used throughout the system. The corresponding MD5 hash has been updated, which is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The glog library is being configured with
-DWITH_GFLAGS=OFF(changed fromON). Since gflags is a dependency and is already being built, this may cause compatibility issues. Consider verifying that glog without gflags integration is intentional and doesn't break existing logging configurations that may depend on gflags.