Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 57 additions & 0 deletions tests/integration/network_stability_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
package pika_integration

import (
"net"
. "github.com/bsm/ginkgo/v2"
. "github.com/bsm/gomega"
)

var _ = Describe("Telnet", func() {
Describe("core dump fix", func() {
It("should handle empty commands without crashing (telnet core dump fix)", func() {
conn, err := net.Dial("tcp", SINGLEADDR)
Expect(err).NotTo(HaveOccurred())
defer conn.Close()

_, err = conn.Write([]byte("\n"))
Expect(err).NotTo(HaveOccurred())

_, err = conn.Write([]byte("*1\r\n$4\r\nPING\r\n"))
Expect(err).NotTo(HaveOccurred())

buf := make([]byte, 1024)
n, err := conn.Read(buf)
Expect(err).NotTo(HaveOccurred())
response := string(buf[:n])
Expect(response).To(ContainSubstring("+PONG"))

_, err = conn.Write([]byte("*2\r\n$4\r\nECHO\r\n$4\r\nTEST\r\n"))
Expect(err).NotTo(HaveOccurred())

n, err = conn.Read(buf)
Expect(err).NotTo(HaveOccurred())
response = string(buf[:n])
Expect(response).To(ContainSubstring("$4\r\nTEST"))
})

It("should handle multiple empty commands without crashing", func() {
conn, err := net.Dial("tcp", SINGLEADDR)
Expect(err).NotTo(HaveOccurred())
defer conn.Close()

for i := 0; i < 5; i++ {
_, err = conn.Write([]byte("\r\n"))
Expect(err).NotTo(HaveOccurred())
}

_, err = conn.Write([]byte("*1\r\n$4\r\nPING\r\n"))
Expect(err).NotTo(HaveOccurred())

buf := make([]byte, 1024)
n, err := conn.Read(buf)
Expect(err).NotTo(HaveOccurred())
response := string(buf[:n])
Expect(response).To(ContainSubstring("+PONG"))
})
})
})
47 changes: 47 additions & 0 deletions tests/integration/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,31 @@ var _ = Describe("Server", func() {
Expect(configRewrite.Err()).NotTo(HaveOccurred())
Expect(configRewrite.Val()).To(Equal("OK"))
})

// Test for cache-value-item-max-size & max-key-size-in-cache
It("should handle cache size configurations correctly", func() {
configGet := client.ConfigGet(ctx, "cache-value-item-max-size")
Expect(configGet.Err()).NotTo(HaveOccurred())
Expect(configGet.Val()).To(HaveKey("cache-value-item-max-size"))

configGet2 := client.ConfigGet(ctx, "max-key-size-in-cache")
Expect(configGet2.Err()).NotTo(HaveOccurred())
Expect(configGet2.Val()).To(HaveKey("max-key-size-in-cache"))

configSet1 := client.ConfigSet(ctx, "cache-value-item-max-size", "1024")
Expect(configSet1.Err()).NotTo(HaveOccurred())
Expect(configSet1.Val()).To(Equal("OK"))

configSet2 := client.ConfigSet(ctx, "max-key-size-in-cache", "1048576")
Expect(configSet2.Err()).NotTo(HaveOccurred())
Expect(configSet2.Val()).To(Equal("OK"))

configGet3 := client.ConfigGet(ctx, "cache-value-item-max-size")
Expect(configGet3.Val()["cache-value-item-max-size"]).To(Equal("1024"))

configGet4 := client.ConfigGet(ctx, "max-key-size-in-cache")
Expect(configGet4.Val()["max-key-size-in-cache"]).To(Equal("1048576"))
})
//It("should DBSize", func() {
// Expect(client.Set(ctx, "key", "value", 0).Val()).To(Equal("OK"))
// Expect(client.Do(ctx, "info", "keyspace", "1").Err()).NotTo(HaveOccurred())
Expand Down Expand Up @@ -794,5 +819,27 @@ var _ = Describe("Server", func() {
Expect(client.Get(ctx, "foo").Err()).To(MatchError(redis.Nil))
Expect(client.Get(ctx, "key1").Err()).To(MatchError(redis.Nil))
})

//fix: added the correct loading of admin-cmd-list in the configuration file
It("should load admin-cmd-list from config correctly", func() {
configGet := client.ConfigGet(ctx, "admin-cmd-list")
Expect(configGet.Err()).NotTo(HaveOccurred())
Expect(configGet.Val()).To(HaveLen(1))

adminCmdList, ok := configGet.Val()["admin-cmd-list"]
Expect(ok).To(BeTrue())

Expect(adminCmdList).To(ContainSubstring("auth"))
Expect(adminCmdList).To(ContainSubstring("config"))
Expect(adminCmdList).To(ContainSubstring("info"))
Expect(adminCmdList).To(ContainSubstring("ping"))
Expect(adminCmdList).To(ContainSubstring("monitor"))
})

// fix add auth command to admin-thread-pool
It("should process auth command in admin thread pool", func() {
auth := client.Do(ctx, "auth", "wrongpassword")
Expect(auth.Err()).To(HaveOccurred())
})
})
})
Loading