Add CryptoCompare Provider With Crypto Historical Support#7290
Open
osasisorae wants to merge 1 commit intoOpenBB-finance:developfrom
Open
Add CryptoCompare Provider With Crypto Historical Support#7290osasisorae wants to merge 1 commit intoOpenBB-finance:developfrom
osasisorae wants to merge 1 commit intoOpenBB-finance:developfrom
Conversation
Contributor
|
Hi, thanks for the PR. Did you mean, Coindesk? CryptoCompare does not appear to be a valid API. |
Author
|
Thanks for flagging this. The implementation does target CryptoCompare’s REST API, and the endpoint still responds to calls like https://min-api.cryptocompare.com/data/v2/histoday?fsym=BTC&tsym=USD. That said, the bottom of their portal now shows a banner (“We’ve migrated our accounts and authentication to CoinDesk”), so it looks like account management is moving under CoinDesk even though the CryptoCompare hostname keeps serving data. Let me know if you’d prefer I rebrand the provider (or wire it directly to CoinDesk’s new auth flow) and I can update the PR accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I introduced an openbb-cryptocompare extension (pyproject, README, plugin wiring) because we needed a first-party provider that follows the documented structure.
I implemented CryptoCompareCryptoHistoricalFetcher covering 1m–1d intervals, VWAP/base-volume fields, and credential handling so users can query standardized OHLCV data from CryptoCompare.
I updated the root providers README to mention CryptoCompare so contributors know it exists.
I added a deterministic pytest that mocks the HTTP helper because we don’t have stable network access in CI.
I ignored .openbb_platform/ in .gitignore because openbb-core writes settings there during tests.
Tests: test_cryptocompare_fetchers.py.
issue #7177