GUI v7 - Second major refactor #1240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ital Read widgets
…to distinguish with upcoming widgetSettings
retiutut
force-pushed
the
independent-widget-settings
branch
from
8d63841 to
2a9ba27
Compare
…ting ourApplet variable and clean up legacy comments in Widgets
retiutut
changed the title
retiutut
force-pushed
the
independent-widget-settings
branch
from
71574c6 to
bdd3dd9
Compare
…Test driven with W_Template
…s and apply this to TimeSeries Widget
There was a problem hiding this comment.
Copilot reviewed 36 out of 56 changed files in this pull request and generated no comments.
Files not reviewed (20)
- OpenBCI_GUI/ADS1299SettingsController.pde: Language not supported
- OpenBCI_GUI/AccelerometerEnums.pde: Language not supported
- OpenBCI_GUI/AnalogReadEnums.pde: Language not supported
- OpenBCI_GUI/BandPowerEnums.pde: Language not supported
- OpenBCI_GUI/ChannelSelect.pde: Language not supported
- OpenBCI_GUI/Containers.pde: Language not supported
- OpenBCI_GUI/ControlPanel.pde: Language not supported
- OpenBCI_GUI/CytonElectrodeStatus.pde: Language not supported
- OpenBCI_GUI/CytonImpedanceEnums.pde: Language not supported
- OpenBCI_GUI/DataLogger.pde: Language not supported
- OpenBCI_GUI/DataProcessing.pde: Language not supported
- OpenBCI_GUI/DataWriterBF.pde: Language not supported
- OpenBCI_GUI/DataWriterODF.pde: Language not supported
- OpenBCI_GUI/EmgJoystickEnums.pde: Language not supported
- OpenBCI_GUI/EnumHelper.pde: Language not supported
- OpenBCI_GUI/Extras.pde: Language not supported
- OpenBCI_GUI/FFTEnums.pde: Language not supported
- OpenBCI_GUI/FifoChannelBar.pde: Language not supported
- OpenBCI_GUI/FileDurationEnum.pde: Language not supported
- OpenBCI_GUI/FocusEnums.pde: Language not supported
…dability and maintainability)
…e issues that cannot be easily fixed #1243
retiutut
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.