refactor some ifdefs

Author: Totto16

src/discord/core.hpp

@@ -21,7 +21,7 @@ namespace constants::discord {
     //TODO: this isn't correct for all platforms and needs to be tested
 #if defined(__ANDROID__)
     constexpr const char* platform_dependent_launch_arguments = "";
-#elif defined(__SWITCH__)
+#elif defined(__CONSOLE__)
 #error "Not supported"
 #elif defined(FLATPAK_BUILD)
     constexpr const char* platform_dependent_launch_arguments = "flatpak run com.github.mgerhold.OOPetris --discord";

src/helper/graphic_utils.cpp

@@ -34,7 +34,7 @@ std::vector<std::string> utils::supported_features() {
         throw std::runtime_error{ "Failed in getting the Pref Path: " + std::string{ SDL_GetError() } };
     }
     return std::filesystem::path{ std::string{ pref_path } };
-#elif defined(__SWITCH__)
+#elif defined(__CONSOLE__)
     // this is in the sdcard of the switch, since internal storage is read-only for applications!
     return std::filesystem::path{ "." };
 
@@ -55,7 +55,7 @@ std::vector<std::string> utils::supported_features() {
 [[nodiscard]] std::filesystem::path utils::get_assets_folder() {
 #if defined(__ANDROID__)
     return std::filesystem::path{ "" };
-#elif defined(__SWITCH__) or defined(__3DS__)
+#elif defined(__CONSOLE__)
     // this is in the internal storage of the nintendo switch, it ios mounted by libnx (runtime switch support library) and filled at compile time with assets (its called ROMFS there)
     return std::filesystem::path{ "romfs:/assets" };
 #elif defined(BUILD_INSTALLER)

src/main.cpp

@@ -62,7 +62,7 @@ int main(int argc, char** argv) {
     std::unique_ptr<Window> window{ nullptr };
 
     try {
-#if defined(__ANDROID__) or defined(__SWITCH__) or defined(__3DS__)
+#if defined(__ANDROID__) or defined(__CONSOLE__)
         window = std::make_unique<Window>(window_name, WindowPosition::Centered);
 #else
         static constexpr int width = 1280;

src/platform/capabilities.hpp

@@ -87,7 +87,7 @@ namespace utils {
 };
 #endif
 
-
+    //TODO: refactor
     [[nodiscard]] constexpr Capabilities get_capabilities() {
 #if defined(__ANDROID__)
         return Capabilities{ false, true, Orientation::Portrait };

src/platform/platform.hpp

@@ -24,7 +24,7 @@ namespace utils {
 
 #if defined(__ANDROID__)
         return "android";
-#elif defined(__SWITCH__) or defined(__3DS__)
+#elif defined(__CONSOLE__)
         return "console";
 #else
         return "pc";