cleanup: de-duplicate code for layout generation

Author: Totto16

src/game/layout.cpp

@@ -0,0 +1,23 @@
+
+#include "./layout.hpp"
+
+std::vector<ui::Layout> game::get_layouts_for(u32 players, const ui::Layout& layout) {
+
+    std::vector<ui::Layout> layouts{};
+    layouts.reserve(players);
+
+    if (players == 0) {
+        throw std::runtime_error("An empty recording file isn't supported");
+    } else if (players == 1) { // NOLINT(readability-else-after-return,llvm-else-after-return)
+        layouts.push_back(ui::RelativeLayout{ layout, 0.02, 0.01, 0.96, 0.98 });
+    } else if (players == 2) {
+        layouts.push_back(ui::RelativeLayout{ layout, 0.02, 0.01, 0.46, 0.98 });
+        layouts.push_back(ui::RelativeLayout{ layout, 0.52, 0.01, 0.46, 0.98 });
+    } else {
+
+        //TODO(Totto): support bigger layouts than just 2
+        throw std::runtime_error("At the moment only replays from up to two players are supported");
+    }
+
+    return layouts;
+}

src/game/layout.hpp

@@ -0,0 +1,15 @@
+
+
+#pragma once
+
+#include <core/helper/types.hpp>
+
+#include "helper/windows.hpp"
+#include "ui/layout.hpp"
+
+
+namespace game {
+    OOPETRIS_GRAPHICS_EXPORTED [[nodiscard]] std::vector<ui::Layout>
+    get_layouts_for(u32 players, const ui::Layout& layout);
+
+}

src/game/meson.build

@@ -9,6 +9,9 @@ graphics_src_files += files(
     'graphic_helpers.hpp',
     'grid.cpp',
     'grid.hpp',
+    'layout.cpp',
+    'layout.hpp',
+
     'rotation.cpp',
     'rotation.hpp',
     'simulated_tetrion.cpp',

src/graphics/video_renderer.cpp

@@ -1,6 +1,7 @@
 
 
 #include "video_renderer.hpp"
+#include "game/layout.hpp"
 
 #include <fmt/format.h>
 
@@ -33,25 +34,10 @@ void VideoRenderer::initialize_games(const std::filesystem::path& recording_path
         shapes::URect{ { 0, 0 }, m_size }
     };
 
-    std::vector<ui::Layout> layouts{};
-    layouts.reserve(parameters.size());
-
-    if (parameters.empty()) {
-        throw std::runtime_error("An empty recording file isn't supported");
-    } else if (parameters.size() == 1) { // NOLINT(readability-else-after-return,llvm-else-after-return)
-        layouts.push_back(ui::RelativeLayout{ layout, 0.02, 0.01, 0.96, 0.98 });
-    } else if (parameters.size() == 2) {
-        layouts.push_back(ui::RelativeLayout{ layout, 0.02, 0.01, 0.46, 0.98 });
-        layouts.push_back(ui::RelativeLayout{ layout, 0.52, 0.01, 0.46, 0.98 });
-    } else {
-
-        //TODO(Totto): support bigger layouts than just 2
-        throw std::runtime_error("At the moment only replays from up to two players are supported");
-    }
+    std::vector<ui::Layout> layouts = game::get_layouts_for(parameters.size(), layout);
 
     m_clock = std::make_shared<ManualClock>();
 
-
     for (decltype(parameters.size()) i = 0; i < parameters.size(); ++i) {
         auto [input, starting_parameters] = std::move(parameters.at(i));
 

src/scenes/replay_game/replay_game.cpp

@@ -1,6 +1,7 @@
 #include "replay_game.hpp"
 #include "../single_player_game/game_over.hpp"
 #include "../single_player_game/pause.hpp"
+#include "game/layout.hpp"
 #include "helper/constants.hpp"
 #include "helper/graphic_utils.hpp"
 #include "helper/music_utils.hpp"
@@ -21,21 +22,7 @@ namespace scenes {
         auto [parameters, information] = input::get_game_parameters_for_replay(service_provider, recording_path);
 
 
-        std::vector<ui::Layout> layouts{};
-        layouts.reserve(parameters.size());
-
-        if (parameters.empty()) {
-            throw std::runtime_error("An empty recording file isn't supported");
-        } else if (parameters.size() == 1) { // NOLINT(readability-else-after-return,llvm-else-after-return)
-            layouts.push_back(ui::RelativeLayout{ layout, 0.02, 0.01, 0.96, 0.98 });
-        } else if (parameters.size() == 2) {
-            layouts.push_back(ui::RelativeLayout{ layout, 0.02, 0.01, 0.46, 0.98 });
-            layouts.push_back(ui::RelativeLayout{ layout, 0.52, 0.01, 0.46, 0.98 });
-        } else {
-
-            //TODO(Totto): support bigger layouts than just 2
-            throw std::runtime_error("At the moment only replays from up to two players are supported");
-        }
+        std::vector<ui::Layout> layouts = game::get_layouts_for(parameters.size(), layout);
 
         u32 simulation_frequency = constants::simulation_frequency;
         if (const auto stored_simulation_frequency = information.get_if<u32>("simulation_frequency");