fix: fix a few minor issues with the video render

Author: Totto16

src/graphics/sdl_context.cpp

@@ -5,6 +5,7 @@
 #include <SDL.h>
 #include <SDL_ttf.h>
 #include <fmt/format.h>
+#include <spdlog/spdlog.h>
 
 #if defined(__CONSOLE__)
 #include "helper/console_helpers.hpp"
@@ -21,6 +22,18 @@ SdlContext::SdlContext() {
         throw helper::InitializationError{ fmt::format("Failed in initializing sdl: {}", SDL_GetError()) };
     }
 
+
+    // when using gdb / lldb to debug and you click something with the mouse, no other application can use the mouse, which is annoying, so not using this feature in debug mode
+#if !defined(NDEBUG)
+    const auto hint_mouse_result = SDL_SetHint(SDL_HINT_MOUSE_AUTO_CAPTURE, "0");
+
+    if (hint_mouse_result != SDL_TRUE) {
+        // this is non fatal, so not returning
+        spdlog::error("Failed to set the SDL_HINT_MOUSE_AUTO_CAPTURE hint: {}", SDL_GetError());
+    }
+#endif
+
+
     if (TTF_Init() < 0) {
         throw helper::InitializationError{ fmt::format("Failed in initializing sdl ttf: {}", TTF_GetError()) };
     }

src/graphics/video_renderer.cpp

@@ -94,12 +94,14 @@ std::optional<std::string> VideoRenderer::render(
     //TODO: this is just a dummy thing atm, change that
     double progress = 0.0;
 
-    while (all_games_finished()) {
+    while (not all_games_finished()) {
         progress_callback(progress);
 
         for (const auto& game : m_games) {
-            game->update();
-            game->render(*this);
+            if (not game->is_game_finished()) {
+                game->update();
+                game->render(*this);
+            }
         }
 
         backend.add_frame(m_surface.get());

src/graphics/video_renderer_linux.cpp

@@ -80,11 +80,9 @@ std::optional<std::string> VideoRendererBackend::setup(u32 fps, shapes::UPoint s
 
 bool VideoRendererBackend::add_frame(SDL_Surface* surface) {
 
-    for (size_t y = surface->h; y > 0; --y) {
-        if (write(m_decoder->pipe, surface->pixels, surface->h * surface->pitch) < 0) {
-            spdlog::error("FFMPEG: failed to write into ffmpeg pipe: {}", strerror(errno));
-            return false;
-        }
+    if (write(m_decoder->pipe, surface->pixels, static_cast<size_t>(surface->h) * surface->pitch) < 0) {
+        spdlog::error("FFMPEG: failed to write into ffmpeg pipe: {}", strerror(errno));
+        return false;
     }
     return true;
 }

src/helper/clock_source.cpp

@@ -68,7 +68,7 @@ double ManualClock::resume() {
 
 
 void ManualClock::increment_simulation_step_index() {
-    m_simulation_step_index++;
+    ++m_simulation_step_index;
 }
 
 void ManualClock::set_simulation_step_index(SimulationStep index) {