clang-tidy: fix all errors

Author: Totto16

src/input/input.cpp

@@ -156,33 +156,28 @@ input::InputManager::InputManager(const std::shared_ptr<Window>& window) {
             /* Terminate the app.
                Shut everything down before returning from this function.
             */
-            return true;
         case SDL_APP_LOWMEMORY:
             /* You will get this when your app is paused and iOS wants more memory.
                Release as much memory as possible.
             */
-            return true;
+
         case SDL_APP_WILLENTERBACKGROUND:
             /* Prepare your app to go into the background.  Stop loops, etc.
                This gets called when the user hits the home button, or gets a call.
             */
-            return true;
         case SDL_APP_DIDENTERBACKGROUND:
             /* This will get called if the user accepted whatever sent your app to the background.
                If the user got a phone call and canceled it, you'll instead get an SDL_APP_DID_ENTER_FOREGROUND event and restart your loops.
                When you get this, you have 5 seconds to save all your state or the app will be terminated.
                Your app is NOT active at this point.
             */
-            return true;
         case SDL_APP_WILLENTERFOREGROUND:
             /* This call happens when your app is coming back to the foreground.
                Restore all your state here.
             */
-            return true;
         case SDL_APP_DIDENTERFOREGROUND:
-
+            return true;
         default:
-
             break;
     }
 

src/manager/music_manager.cpp

@@ -40,7 +40,7 @@ MusicManager::MusicManager(ServiceProvider* service_provider, u8 channel_size)
     }
 
     // retrieve allocated channels
-    auto allocated_channels = Mix_AllocateChannels(-1);
+    const auto allocated_channels = Mix_AllocateChannels(-1);
 
     spdlog::debug("SDL_MIX: allocated_channels = {}", allocated_channels);
 
@@ -76,7 +76,8 @@ MusicManager::~MusicManager() noexcept {
     }
 
     // stop sounds and free loaded data
-    int result = Mix_HaltChannel(-1);
+    const int result = Mix_HaltChannel(-1);
+
     if (result != 0) {
         spdlog::warn("Mix_HaltChannel failed with error: {}", SDL_GetError());
     }
@@ -264,7 +265,7 @@ void MusicManager::hook_music_finished() {
 
 [[nodiscard]] std::optional<double> MusicManager::get_volume() const {
 #if !defined(NDEBUG)
-    int result = Mix_VolumeMusic(-1);
+    const int result = Mix_VolumeMusic(-1);
     if (result == 0) {
         return std::nullopt;
     }