clang-tidy: fix all errors

Author: Totto16

.github/workflows/cpp-linter.yml

@@ -48,7 +48,7 @@ jobs:
           tidy-checks: ""
           step-summary: true
           file-annotations: true
-          ignore: subprojects|build|android|assets|recordings|docs|toolchains|platforms|src/libs/core/hash-library|wrapper/javascript/
+          ignore: subprojects|build|android|assets|recordings|docs|toolchains|platforms|wrapper|src/libs/core/hash-library
 
       - name: Fail CI run if linter checks failed
         if: steps.linter.outputs.checks-failed != 0

src/scenes/online_lobby/online_lobby.cpp

@@ -31,7 +31,7 @@ namespace scenes {
         //TODO(Totto): after the settings have been reworked, make this url changeable!
         auto maybe_client = lobby::Client::get_client("http://127.0.0.1:5000");
         if (maybe_client.has_value()) {
-            client = std::make_unique<lobby::Client>(std::move(maybe_client.value()));
+            m_client = std::make_unique<lobby::Client>(std::move(maybe_client.value()));
         } else {
             spdlog::error("Error in connecting to lobby client: {}", maybe_client.error());
         }

src/scenes/online_lobby/online_lobby.hpp

@@ -17,7 +17,7 @@ namespace scenes {
 
         ui::TileLayout m_main_layout;
         std::optional<Command> m_next_command;
-        std::unique_ptr<lobby::Client> client{ nullptr };
+        std::unique_ptr<lobby::Client> m_client{ nullptr };
 
     public:
         explicit OnlineLobby(ServiceProvider* service_provider, const ui::Layout& layout);