fix: fix the color format of the sdl surface + do a correct sdl render loop, so that the image gets cleared correctly

Author: Totto16

src/graphics/video_renderer.cpp

@@ -83,13 +83,17 @@ std::optional<std::string> VideoRenderer::render(
     while (not all_games_finished()) {
         progress_callback(progress);
 
+        m_renderer->clear();
+
         for (const auto& game : m_games) {
             if (not game->is_game_finished()) {
                 game->update();
                 game->render(*this);
             }
         }
 
+        m_renderer->present();
+        
         backend.add_frame(m_surface.get());
         m_clock->increment_simulation_step_index();
 

src/graphics/video_renderer_linux.cpp

@@ -57,11 +57,10 @@ std::optional<std::string> VideoRendererBackend::setup(u32 fps, shapes::UPoint s
 
         //TODO(Totto): support audio, that loops the music as in the main game
         int ret =
-                execlp("ffmpeg", "ffmpeg", "-loglevel", "verbose", "-y",
-
-                       "-f", "rawvideo", "-pix_fmt", "rgba", "-s", resolution.c_str(), "-r", framerate.c_str(), "-i",
-                       "-", "-c:v", "libx264", "-vb", "2500k", "-c:a", "aac", "-ab", "200k", "-pix_fmt", "yuv420p",
-                       m_destination_path.c_str(), static_cast<char*>(nullptr));
+                execlp("ffmpeg", "ffmpeg", "-loglevel", "verbose", "-y", "-f", "rawvideo", "-pix_fmt", "bgra", "-s",
+                       resolution.c_str(), "-r", framerate.c_str(), "-i", "-", "-c:v", "libx264", "-vb", "2500k",
+                       "-c:a", "aac", "-ab", "200k", "-pix_fmt", "yuv420p", m_destination_path.c_str(),
+                       static_cast<char*>(nullptr));
         if (ret < 0) {
             std::cerr << "FFMPEG CHILD: could not run ffmpeg as a child process: " << strerror(errno) << "\n";
             std::exit(1);