-
Notifications
You must be signed in to change notification settings - Fork 534
[connectors-sdk] BaseConnectorSettings support for connectors as module
#5323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[connectors-sdk] BaseConnectorSettings support for connectors as module
#5323
Conversation
bad0e3d to
0ea3684
Compare
0ea3684 to
20e2a14
Compare
Kakudou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, every things looks good to me, some small QoL suggestions, but nothing really important.
All tests working on my side, 🚀
patching pydantic-settings directly was hiding the files' parsing in tests
20e2a14 to
9d91245
Compare
Kakudou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for me, ty for the QoL improvements you've added !
__main__.__file__is not always available at module import time, but is at runtime. So, my main contribution was to do the tests to confirm that theconnectors-sdkcan work with the connectors developed as modules.Proposed changes
_SettingsLoader.settings_customise_sourcesto their own methods__main__.__file__is not available at runtime (for very rare cases)Related issues
BaseConnectorSettingsdoes not work with connector as module #5295Checklist