Skip to content

Conversation

@Powlinett
Copy link
Member

@Powlinett Powlinett commented Dec 3, 2025

__main__.__file__ is not always available at module import time, but is at runtime. So, my main contribution was to do the tests to confirm that the connectors-sdk can work with the connectors developed as modules.

Proposed changes

  • extract the logic to locate config files from _SettingsLoader.settings_customise_sources to their own methods
  • raise meaningful error if __main__.__file__ is not available at runtime (for very rare cases)
  • update unit tests to really read from filesystem (not mocking files' content anymore)

Related issues

Checklist

  • I consider the submitted work as finished
  • I have signed my commits using GPG key.
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@Powlinett Powlinett force-pushed the bug/5295-connectors-sdk-base-connector-settings-not-working-with-modules branch from bad0e3d to 0ea3684 Compare December 3, 2025 15:06
@Powlinett Powlinett added filigran team use to identify PR from the Filigran team connectors-sdk labels Dec 3, 2025
@Powlinett Powlinett marked this pull request as ready for review December 3, 2025 15:45
@Powlinett Powlinett force-pushed the bug/5295-connectors-sdk-base-connector-settings-not-working-with-modules branch from 0ea3684 to 20e2a14 Compare December 12, 2025 08:41
Kakudou
Kakudou previously approved these changes Dec 12, 2025
Copy link
Member

@Kakudou Kakudou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, every things looks good to me, some small QoL suggestions, but nothing really important.

All tests working on my side, 🚀

@Powlinett Powlinett force-pushed the bug/5295-connectors-sdk-base-connector-settings-not-working-with-modules branch from 20e2a14 to 9d91245 Compare January 5, 2026 14:35
@Powlinett Powlinett requested a review from Kakudou January 5, 2026 14:37
Copy link
Member

@Kakudou Kakudou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me, ty for the QoL improvements you've added !

@Powlinett Powlinett merged commit ac788e6 into master Jan 7, 2026
6 checks passed
@Powlinett Powlinett deleted the bug/5295-connectors-sdk-base-connector-settings-not-working-with-modules branch January 7, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

connectors-sdk filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[connectors-sdk] BaseConnectorSettings does not work with connector as module

3 participants