Skip to content

[silentpush-enrichment] Verify connector #5431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
throuxel merged 2 commits into from
Dec 31, 2025
Merged

[silentpush-enrichment] Verify connector #5431

throuxel merged 2 commits into from
Dec 31, 2025

Conversation

@throuxel
Copy link
Member

@throuxel throuxel commented Dec 16, 2025 •
edited
Loading

Proposed changes

  • Refactor connector using templates and sdk models
  • Make the connector is manager supported

Related issues

Checklist

  • I consider the submitted work as finished
  • I have signed my commits using GPG key.
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

For Filigran team, if you want to test, keep auto to False (we only have 50 api calls per day).

@throuxel throuxel self-assigned this Dec 16, 2025
@throuxel throuxel added filigran team use to identify PR from the Filigran team filigran verify Use to identify PR of connector Verified connector: silentpush-enrichment labels Dec 16, 2025
@helene-nguyen helene-nguyen linked an issue Dec 17, 2025 that may be closed by this pull request
[silentpush-enrichment] Verify + add connector in the catalog #5169
Closed
jabesq
jabesq requested changes Dec 18, 2025
View reviewed changes
Copy link
Member

@jabesq jabesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested (after fixing requirements.txt) with success, enrichment done automatically and with playbook.

Image

@throuxel throuxel force-pushed the feat/5169-verify-silentpush branch 2 times, most recently from 3c099b2 to 9e7242a Compare December 22, 2025 09:54
@throuxel throuxel requested a review from jabesq December 22, 2025 09:55
jabesq
jabesq previously approved these changes Dec 22, 2025
View reviewed changes
Copy link
Member

@jabesq jabesq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@throuxel throuxel force-pushed the feat/5169-verify-silentpush branch from 9e7242a to 7fafb66 Compare December 31, 2025 08:34
@throuxel throuxel force-pushed the feat/5169-verify-silentpush branch from 7fafb66 to 45ae21e Compare December 31, 2025 10:08
@throuxel throuxel force-pushed the feat/5169-verify-silentpush branch from 45ae21e to ff5dc49 Compare December 31, 2025 10:16
@throuxel
Copy link
Member Author

throuxel commented Dec 31, 2025

Tested locally with connector composer ✔️
image

@throuxel throuxel merged commit f914d93 into master Dec 31, 2025
6 checks passed
@throuxel throuxel deleted the feat/5169-verify-silentpush branch December 31, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jabesq jabesq jabesq approved these changes

@mariot mariot Awaiting requested review from mariot

@Kakudou Kakudou Awaiting requested review from Kakudou

@Megafredo Megafredo Awaiting requested review from Megafredo

@Ninoxe Ninoxe Awaiting requested review from Ninoxe

@Powlinett Powlinett Awaiting requested review from Powlinett

@helene-nguyen helene-nguyen Awaiting requested review from helene-nguyen

Assignees

@throuxel throuxel

Labels

connector: silentpush-enrichment filigran team use to identify PR from the Filigran team filigran verify Use to identify PR of connector Verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[silentpush-enrichment] Verify + add connector in the catalog

3 participants

@throuxel @jabesq