Skip to content

[shodan] Shodan Results note is not correctly formatted #5475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
romain-filigran merged 2 commits into from
Jan 16, 2026
Merged

[shodan] Shodan Results note is not correctly formatted #5475

romain-filigran merged 2 commits into from
Jan 16, 2026

Conversation

@romain-filigran
Copy link
Member

@romain-filigran romain-filigran commented Dec 24, 2025

Proposed changes

  • Update note content creation to correctly display results. Also a note type (external) and change the note title to prevent to have thousand of note with the same title

Related issues

Checklist

  • I consider the submitted work as finished
  • I have signed my commits using GPG key.
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • [ ]

Further comments

@romain-filigran romain-filigran added filigran team use to identify PR from the Filigran team filigran verify Use to identify PR of connector Verified labels Dec 24, 2025
@romain-filigran romain-filigran linked an issue Dec 24, 2025 that may be closed by this pull request
[shodan] Shodan Results note is not correctly formatted #5473
Closed
@SamuelHassine SamuelHassine force-pushed the master branch 2 times, most recently from a35f198 to 34b8e57 Compare January 9, 2026 14:33
@romain-filigran romain-filigran merged commit 5d01578 into master Jan 16, 2026
6 checks passed
@romain-filigran romain-filigran deleted the bug/5473 branch January 16, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maximerafaillac maximerafaillac maximerafaillac approved these changes

Assignees

@romain-filigran romain-filigran

Labels

filigran team use to identify PR from the Filigran team filigran verify Use to identify PR of connector Verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[shodan] Shodan Results note is not correctly formatted

3 participants

@romain-filigran @maximerafaillac