[backup-files] remove live as default value #5489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariot
added
feature
Powlinett
reviewed
Jan 5, 2026
Member
Powlinett
left a comment
Powlinett
left a comment
There was a problem hiding this comment.
The connector behaves as expected 👍
Please see my suggestion below.
|
|
||
| def check_helper(helper: OpenCTIConnectorHelper) -> None: | ||
| if ( | ||
| helper.connect_live_stream_id is None |
Member
There was a problem hiding this comment.
I'd rather use not helper.connect_live_stream_id instead of helper.connector_live_stream_id is None to handle empty strings too.
mariot
force-pushed
the
feat/5488-remove-live
branch
from
84db4c0 to
f136af7
Compare
Powlinett
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments