Skip to content

[shadowserver] Fix report types and add report names config#6127

Merged
throuxel merged 2 commits intomasterfrom
fix/6061-shadowserver-report-type
Mar 31, 2026
Merged

[shadowserver] Fix report types and add report names config#6127
throuxel merged 2 commits intomasterfrom
fix/6061-shadowserver-report-type

Conversation

@throuxel
Copy link
Copy Markdown
Member

Proposed changes

  • Fix report types and add report names config

Related issues

Checklist

  • I consider the submitted work as finished
  • I have signed my commits using GPG key.
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@throuxel throuxel requested review from Ninoxe, Powlinett and jabesq March 30, 2026 16:02
@throuxel throuxel self-assigned this Mar 30, 2026
@throuxel throuxel added filigran team use to identify PR from the Filigran team connector: shadowserver labels Mar 30, 2026
@ncarenton ncarenton self-requested a review March 31, 2026 07:40
@throuxel throuxel force-pushed the fix/6061-shadowserver-report-type branch from fddafc0 to aa4d053 Compare March 31, 2026 13:25
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@957357b). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##             master   #6127   +/-   ##
========================================
  Coverage          ?   1.22%           
========================================
  Files             ?    1633           
  Lines             ?   98161           
  Branches          ?       0           
========================================
  Hits              ?    1204           
  Misses            ?   96957           
  Partials          ?       0           
Flag Coverage Δ
baseline 0.00% <0.00%> (?)
connectors 93.11% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@throuxel throuxel force-pushed the fix/6061-shadowserver-report-type branch from aa4d053 to ccdcd83 Compare March 31, 2026 13:43
Copy link
Copy Markdown
Member

@ncarenton ncarenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Image

@throuxel throuxel merged commit 875f8d8 into master Mar 31, 2026
16 checks passed
@throuxel throuxel deleted the fix/6061-shadowserver-report-type branch March 31, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

connector: shadowserver filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Shadowserver] SHADOWSERVER_REPORT_TYPES filter has no effect - wrong API parameter used (reports vs type)

2 participants