Skip to content

Conversation

@MTorbay-Filigran
Copy link
Member

@MTorbay-Filigran MTorbay-Filigran commented Dec 11, 2025

Proposed changes

  • Changed css rules in darkTheme and lightTheme

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@MTorbay-Filigran MTorbay-Filigran added this to the Next Milestone milestone Dec 11, 2025
@MTorbay-Filigran MTorbay-Filigran self-assigned this Dec 11, 2025
@MTorbay-Filigran MTorbay-Filigran changed the base branch from master to release/current December 11, 2025 16:31
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 2.61%. Comparing base (c5a284e) to head (8e34d59).
⚠️ Report is 2 commits behind head on release/current.

Files with missing lines Patch % Lines
...urity_coverages/SecurityCoverageAttackPatterns.tsx 0.00% 3 Missing ⚠️
...s/entity_setting/EntitySettingAttributeEdition.tsx 0.00% 1 Missing ⚠️
...b_types/entity_setting/EntitySettingAttributes.tsx 0.00% 1 Missing ⚠️
...ncti-front/src/public/components/SystemBanners.jsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           release/current   #13646      +/-   ##
===================================================
+ Coverage             2.60%    2.61%   +0.01%     
===================================================
  Files                 2130     2130              
  Lines               109688   109722      +34     
  Branches             29887    29916      +29     
===================================================
+ Hits                  2856     2874      +18     
- Misses              106832   106848      +16     
Flag Coverage Δ
opencti 2.61% <0.00%> (+0.01%) ⬆️
opencti-front 2.61% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Thank you for your contribution, but we need you to sign your commits. Please see https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Copy link
Member

@lndrtrbn lndrtrbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS capitalizeFirstLetter function would change the translation key. I think it would be better to manage all the changes using CSS like you did in Theme files

@Archidoit
Copy link
Member

Archidoit commented Jan 5, 2026

In a container 'entities' or 'observables' tab: the icons at the left are not of the same height and thus not aligned :

image

@Archidoit
Copy link
Member

Difference of first letter style between FilterIconButton and its tooltip :
image

@lndrtrbn
Copy link
Member

lndrtrbn commented Jan 5, 2026

In a container 'entities' or 'observables' tab: the icons at the left are not of the same height and thus not aligned :

This is not caused by this PR, @esrevi an issue from button refactoring I guess

@Archidoit
Copy link
Member

Security coverage icon has changed
Your branch:
image

prerelease:
image

@Archidoit
Copy link
Member

Archidoit commented Jan 5, 2026

Column names of components under ListLines are still in capital letters (exemple: roles and groups lists, monitoring tab, support package list, analyses tab of an entity, sightings tab of an observable, knowledge tabs...) :

image image image image

@Archidoit
Copy link
Member

'Register in XTM Hub' button is still in capital:
image

@Archidoit
Copy link
Member

'Next' and 'create' button of file import pop-up are in capital :
image

@Archidoit
Copy link
Member

Missing capital first letter in 'Data' tab of an entity for 'Drafts' :
image

@Archidoit
Copy link
Member

Archidoit commented Jan 5, 2026

'Continue' button in capital letter when creating a relationship from an entity :

image

@Archidoit
Copy link
Member

First capital letter for 'Fintel templates' in Customization of a container :
image

@Archidoit
Copy link
Member

In Advanced Search > Files search:
column names are in capital and 'files search' tab has no capital first letter

image

@MTorbay-Filigran
Copy link
Member Author

JS capitalizeFirstLetter function would change the translation key. I think it would be better to manage all the changes using CSS like you did in Theme files

I let it only when it was not used with t_i18n, is it okay like this ?

@MTorbay-Filigran
Copy link
Member Author

entities' or 'observables' tab

Also on release current, not due to this PR

@MTorbay-Filigran
Copy link
Member Author

Missing capital first letter in 'Data' tab of an entity for 'Drafts' :

Resolved by another PR

@MTorbay-Filigran
Copy link
Member Author

First capital letter for 'Fintel templates' in Customization of a container :
Fixed in another PR

@Archidoit
Copy link
Member

There is still a difference of style between a filter icon button and its tooltip :
image

By the way, I think it would be better to write the filter key label with a first letter in capital.

@Archidoit
Copy link
Member

'Browse more' button is in capital letters in Data>Ingestion>Connector catalog :
image

@Archidoit
Copy link
Member

Missing first letter in capital in : an attack pattern > create a relationship button > create an observable/entity button > select an observable type :

image image

@lndrtrbn lndrtrbn marked this pull request as ready for review January 7, 2026 13:59
@MTorbay-Filigran MTorbay-Filigran force-pushed the issue/13453 branch 2 times, most recently from 3494697 to b878d1c Compare January 7, 2026 16:23
@MTorbay-Filigran MTorbay-Filigran merged commit 5e6f379 into release/current Jan 8, 2026
39 checks passed
@MTorbay-Filigran MTorbay-Filigran deleted the issue/13453 branch January 8, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants