-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[FRONTEND] Change Uppercases to sentence case #13646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
49df894 to
3c50084
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/current #13646 +/- ##
===================================================
+ Coverage 2.60% 2.61% +0.01%
===================================================
Files 2130 2130
Lines 109688 109722 +34
Branches 29887 29916 +29
===================================================
+ Hits 2856 2874 +18
- Misses 106832 106848 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
32352fe to
41f2d50
Compare
41f2d50 to
ce48bfb
Compare
|
Thank you for your contribution, but we need you to sign your commits. Please see https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
c1ea603 to
38eaaa8
Compare
lndrtrbn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JS capitalizeFirstLetter function would change the translation key. I think it would be better to manage all the changes using CSS like you did in Theme files
This is not caused by this PR, @esrevi an issue from button refactoring I guess |
341251f to
fc53812
Compare
I let it only when it was not used with t_i18n, is it okay like this ? |
Also on release current, not due to this PR |
fc53812 to
50cd8a0
Compare
Resolved by another PR |
|
58cd1bb to
871d860
Compare
…t and dark themes
3494697 to
b878d1c
Compare
6c55851 to
13616b7
Compare


















Proposed changes
Related issues
Checklist
Further comments