[frontend] refacto objectOrganisationFIeld jsx to tsx #13781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13781 +/- ##
=======================================
Coverage 30.79% 30.80%
=======================================
Files 2907 2907
Lines 192125 192166 +41
Branches 39165 39187 +22
=======================================
+ Hits 59166 59188 +22
- Misses 132959 132978 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SamuelHassine
force-pushed
the
master
branch
8 times, most recently
from
1c222ef to
2cb4539
Compare
Archidoit
reviewed
Jan 15, 2026
| // Deprecated - https://mui.com/system/styles/basics/ | ||
| // Do not use it for new code. | ||
| const useStyles = makeStyles(() => ({ | ||
| const useStyles = makeStyles<Theme>(() => ({ |
Member
There was a problem hiding this comment.
makeStyles is deprecated, you should rather integrate the styles directly in the html :)
Archidoit
reviewed
Jan 15, 2026
| const handleChangeObjectOrganization = ( | ||
| name: string, | ||
| values: { label: string; value: string }[], | ||
| value: FieldOption[], |
Member
There was a problem hiding this comment.
you can keep the denomination 'values' since it's an array
Archidoit
reviewed
Jan 15, 2026
| const handleChangeObjectOrganization = ( | ||
| name: string, | ||
| values: { label: string; value: string }[], | ||
| value: FieldOption[], |
Member
There was a problem hiding this comment.
Suggested change
| value: FieldOption[], | |
| values: FieldOption[], |
Archidoit
requested changes
Jan 15, 2026
| setOrganizations(searchResults); | ||
| }); | ||
| const searchOrganizations = (event?: SyntheticEvent<Element, Event>) => { | ||
| if (event?.target instanceof HTMLInputElement) { |
Member
There was a problem hiding this comment.
you are changing the behavior with this if, you can remove it if you event is typed correctly (BaseSyntheticEvent)
| })); | ||
| setOrganizations(searchResults); | ||
| }); | ||
| const searchOrganizations = (event?: SyntheticEvent<Element, Event>) => { |
Member
There was a problem hiding this comment.
Suggested change
| const searchOrganizations = (event?: SyntheticEvent<Element, Event>) => { | |
| const searchOrganizations = (event?: BaseSyntheticEvent) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist