Skip to content

Conversation

@lndrtrbn
Copy link
Member

@lndrtrbn lndrtrbn commented Jan 7, 2026

Proposed changes

  • Same size and spacing for all headers of entities

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@lndrtrbn lndrtrbn self-assigned this Jan 7, 2026
@lndrtrbn lndrtrbn added the filigran team use to identify PR from the Filigran team label Jan 7, 2026
@lndrtrbn lndrtrbn marked this pull request as ready for review January 7, 2026 11:05
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 0% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.83%. Comparing base (317eb78) to head (72ce55b).
⚠️ Report is 33 commits behind head on release/current.

Files with missing lines Patch % Lines
...nt/src/private/components/settings/groups/Root.tsx 0.00% 8 Missing ⚠️
...ont/src/private/components/settings/roles/Root.tsx 0.00% 8 Missing ⚠️
...es/external_references/ExternalReferenceHeader.tsx 0.00% 6 Missing ⚠️
...components/settings/fintel_design/FintelDesign.tsx 0.00% 6 Missing ⚠️
...ont/src/private/components/settings/users/Root.jsx 0.00% 6 Missing ⚠️
...e/components/common/containers/ContainerHeader.jsx 0.00% 5 Missing ⚠️
...ivate/components/data/playbooks/PlaybookHeader.tsx 0.00% 5 Missing ⚠️
...ents/settings/case_templates/CaseTemplateTasks.tsx 0.00% 5 Missing ⚠️
...tform/opencti-front/src/components/Breadcrumbs.tsx 0.00% 3 Missing ⚠️
...c/components/common/typography/TitleMainEntity.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           release/current   #13924       +/-   ##
====================================================
+ Coverage             2.58%   30.83%   +28.25%     
====================================================
  Files                 2127     2928      +801     
  Lines               109368   193503    +84135     
  Branches             29834    39735     +9901     
====================================================
+ Hits                  2825    59673    +56848     
- Misses              106543   133830    +27287     
Flag Coverage Δ
opencti 30.83% <0.00%> (+28.25%) ⬆️
opencti-front 2.75% <0.00%> (+0.16%) ⬆️
opencti-graphql 68.23% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@esrevi esrevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lndrtrbn lndrtrbn merged commit 1555b53 into release/current Jan 7, 2026
39 checks passed
@lndrtrbn lndrtrbn deleted the issue/13454 branch January 7, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants