-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[frontend] Update to ESM (#14044) #14045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
xfournet
wants to merge
3
commits into
master
Choose a base branch
from
issue/14044-frontend-esm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+97
−134
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 5 additions & 5 deletions
10
opencti-platform/opencti-front/builder/plugin/esbuild-relay.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 5 additions & 2 deletions
7
opencti-platform/opencti-front/packages/eslint-plugin-custom-rules/lib/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,5 @@ | ||
| const requireIndex = require("requireindex"); | ||
| module.exports.rules = requireIndex(__dirname + "/rules"); | ||
| import classesRules from './rules/classes-rule.js'; | ||
|
|
||
| export default { | ||
| 'classes-rule': classesRules, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 1 addition & 3 deletions
4
opencti-platform/opencti-front/packages/eslint-plugin-custom-rules/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 5 additions & 5 deletions
10
...rm/opencti-front/packages/eslint-plugin-custom-rules/tests/lib/rules/classes-rule.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,19 @@ | ||
| const fs = require('fs'); | ||
| const path = require('path'); | ||
| import { readFile, readdir } from 'node:fs/promises'; | ||
| import path from 'node:path'; | ||
xfournet marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| function sortJSONKeys(json) { | ||
| const sortJSONKeys = (json) => { | ||
| const sortedKeys = Object.keys(json).sort((a, b) => a.toLowerCase().localeCompare(b.toLowerCase())); | ||
| const sortedJSON = {}; | ||
| sortedKeys.forEach(key => { | ||
| sortedKeys.forEach((key) => { | ||
| sortedJSON[key] = json[key]; | ||
| }); | ||
| return sortedJSON; | ||
| } | ||
|
||
|
|
||
| function sortJSONFile(filePath) { | ||
| const sortJSONFile = async (filePath) => { | ||
| try { | ||
| // Read JSON file | ||
| const jsonData = JSON.parse(fs.readFileSync(filePath, 'utf8')); | ||
| const jsonData = JSON.parse(await readFile(filePath, 'utf8')); | ||
|
|
||
| // Sort JSON keys | ||
| const sortedJSON = sortJSONKeys(jsonData); | ||
|
|
@@ -27,13 +27,13 @@ function sortJSONFile(filePath) { | |
| } | ||
| } | ||
|
|
||
| function sortAllJSONFiles(dirPath) { | ||
| const sortAllJSONFiles = async (dirPath) => { | ||
| try { | ||
| // Get list of files in directory | ||
| const files = fs.readdirSync(dirPath); | ||
| const files = await readdir(dirPath); | ||
|
|
||
| // Iterate through files | ||
| files.forEach(file => { | ||
| for await (const file of files) { | ||
| const filePath = path.join(dirPath, file); | ||
|
|
||
| // Skip if not a JSON file or if it's en.json | ||
|
|
@@ -42,12 +42,12 @@ function sortAllJSONFiles(dirPath) { | |
| } | ||
|
|
||
| // Sort JSON file | ||
| sortJSONFile(filePath); | ||
| }); | ||
| await sortJSONFile(filePath); | ||
| } | ||
| } catch (err) { | ||
| console.error('Error reading directory:', err); | ||
| } | ||
| } | ||
|
|
||
| sortAllJSONFiles('lang/front'); | ||
| sortAllJSONFiles('lang/back'); | ||
| await sortAllJSONFiles('lang/front'); | ||
| await sortAllJSONFiles('lang/back'); | ||
xfournet marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.