Open
Conversation
Needs some hackery to initialize the replication sets
There was a problem hiding this comment.
Pull Request Overview
This PR updates container images and configuration to enable core support on arm64 platforms by switching to newer images and customizing the MongoDB service to handle replication set initialization. Key changes include:
- Updating healthcheck parameters for MariaDB.
- Switching the MongoDB container from a Bitnami image to the official mongo:7 image with custom replica set initialization in the healthcheck.
- Upgrading several service images (mujina-idp, oidcplaygroundgui, oidcplaygroundserver, teamsgui, and teamserver) to use the latest tags.
Comments suppressed due to low confidence (1)
core/docker-compose.yml:69
- Environment variable inconsistency detected: the replica set name is defined as 'MONGO_REPLICA_SET_NAME' in the environment block (line 52) but referenced as 'MONGODB_RS_NAME' here. Consider aligning these variable names for clarity.
_id : "${MONGODB_RS_NAME:-openconext}",
There was a problem hiding this comment.
Pull Request Overview
This PR updates core services to run on arm64 by switching to images that support this architecture and handling MongoDB replication setup manually.
- Adjusted MariaDB healthcheck timings
- Replaced Bitnami Mongo image with the official
mongo:7, added keyfile-based auth and a mongosh-driven replica set initialization - Upgraded several OpenConext service images to use the
latesttag
Comments suppressed due to low confidence (1)
core/docker-compose.yml:127
- [nitpick] Using the
latesttag can lead to non-reproducible builds when images change unexpectedly. Consider pinning to a specific version to ensure determinism.
image: ghcr.io/openconext/mujina/mujina-idp:latest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the containers simply needed to switch to a newer version (that includes arm64 builds in the container images). Only for Mongo some work work was necessary: the bitnami container don't support arm64 (for bureaucratic reasons), so we switch to the official mongo images. That required some hackery to initialise the replication set, which the bitnami containers handled internally in the entrypoint scripts.