Skip to content

Do not log stacktrace if no session was found#320

Merged
oharsta merged 3 commits intomainfrom
feature/clean_CookiesNotSupportedException
Feb 10, 2026
Merged

Do not log stacktrace if no session was found#320
oharsta merged 3 commits intomainfrom
feature/clean_CookiesNotSupportedException

Conversation

@phavekes
Copy link
Member

@phavekes phavekes commented Feb 10, 2026

This CookiesNotSupportedException happens very often. Do not log the full stacktrace, but log information we can use instead

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.92%. Comparing base (b921b79) to head (0f2d129).

Files with missing lines Patch % Lines
...in/java/oidc/saml/AuthnRequestContextConsumer.java 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #320      +/-   ##
============================================
- Coverage     89.98%   89.92%   -0.06%     
- Complexity      665      667       +2     
============================================
  Files            86       86              
  Lines          2416     2423       +7     
  Branches        275      276       +1     
============================================
+ Hits           2174     2179       +5     
- Misses          129      130       +1     
- Partials        113      114       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oharsta oharsta merged commit 9eb2564 into main Feb 10, 2026
1 check failed
@github-project-automation github-project-automation bot moved this from New to Delivered in OpenConext-oidcng Feb 10, 2026
@oharsta oharsta deleted the feature/clean_CookiesNotSupportedException branch February 10, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Delivered

Development

Successfully merging this pull request may close these issues.

2 participants