Rework TypeId stuff at SubscriberImpl to be dynamic modules friendly
#396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation #docs #sonar
# Conflicts: # docs/examples/1_presentation/example_10_posix_udp.cpp # include/libcyphal/presentation/presentation.hpp
Simplified registry implementation by... - removing user specific coercion logic - now API based on either the Nunavut's `Value` type or one of its variants; - only `Registry::route` method left - `expose` and `parameterize` were removed (b/c they depend on the coercion)
- Defined abstract key-value storage interface; plus its mock under unit tests. - Added `load` & `save` methods for persisting registry in a storage; its unit test coverage (100%). - Extended example_2_app_0 with registry persisting.
…tor` stays with specific memory resource (instead of default "new/delete" one) #verification #docs #sonar
…ification #docs #sonar
Set default PMR, so that default behavior of `std::pmr::polymorphic_allocator` stays with specific memory resource (instead of default "new/delete" one) #verification #docs #sonar
# Conflicts: # .github/workflows/sonar.yml # .github/workflows/tests.yml
# Conflicts: # .github/workflows/sonar.yml # .github/workflows/tests.yml # docs/examples/1_presentation/example_1_presentation_1_ping_user_service_udp.cpp # docs/examples/2_application/example_2_application_0_node_hb_getinfo_udp.cpp # include/libcyphal/application/registry/register.hpp # include/libcyphal/presentation/client.hpp # include/libcyphal/presentation/publisher.hpp # include/libcyphal/presentation/server.hpp # test/unittest/application/node/test_get_info_provider.cpp
serges147
changed the title
SubscriberImpl to be dynamic modules friendlyTypeId stuff at SubscriberImpl to be dynamic modules friendly
|
pavel-kirienko
approved these changes
Nov 11, 2024
thirtytwobits
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeIdstuff atSubscriberImplto be dynamic modules friendly. #380 reworked subscriber's message type id generation - now Nunavut'sFullNameAndVersionconst string is in use to generate type id (string hash). No more unsafe (dynamic modules non-friendly) conversion of address of template static variable tostd::uintptr_t.Also:
GetInfoProvider::setXxxsetters<Type>::_traits_::ArrayCapacity::<field>now in use