Fix for issue #412 Only one single RPC client is possible per port (#415) #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) 1. Response Rx Session now doesn't own lizard's rpc port subscription - instead now session references the shared subscription (with reference counting). 2. Transport delegates now manage subscriptions. 3. CAN Response Rx Sessions now stored in cavl tree (for UDP it was already like this) - matching now by both port and node ids (previously it was by the port only). 4. CAN filters now also are made by the delegate (b/c it knows about subscriptions (see bullet # 2). 5. Extended unit tests to cover multiple response Rx sessions (both CAN and UDP). Also covered unsolicited responses. Github's Hide whitespaces is recommended.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github's Hide whitespaces is recommended.