Upgrade to Daffodil 4.1.0 / ACE 12+13, add SimpleEDI schema and setup script#28
Open
matthiasblomme wants to merge 11 commits intoOpenDFDL:masterfrom
Open
Upgrade to Daffodil 4.1.0 / ACE 12+13, add SimpleEDI schema and setup script#28matthiasblomme wants to merge 11 commits intoOpenDFDL:masterfrom
matthiasblomme wants to merge 11 commits intoOpenDFDL:masterfrom
Conversation
Upgrade to Daffodil 4.1.0 / ACE 12+13, add SimpleEDI schema and setup script
Add ad-hoc validator script and how-to guide
Make sbt path configurable via -SbtPath parameter
Add demo schema and Discord community link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IBM_DFDL.scala): updated imports fromlib.api→lib.iapi, replaced removedValidationModeenum withwithValidation(String), updatedgetProcessorsignature (removeduseSerializedProcessor), fixedgetDiagnosticsreturn type tojava.util.List, updatedDiagnosticconstructor call, fixedEmbeddedSchemaSource.copyto pass all args, and adopted Scala 3 vararg syntax.-java-homeflag for sbt, pointing at the Java 17 bundled with ACE.protobuf-java-3.25.5.jar,ibm-dfdl-eclipse-dependencies.jar,icu4j-charset.jar, new EMF jar names).scd.jaris no longer shipped.setup-ace-jars.ps1: new PowerShell setup script that copies all required DFDL runtime jars and IBM sample files from an ACE installation into the project. Accepts-AceVersion 12|13(defaults to 12) or-AcePath <custom path>for non-standard install locations.SimpleEDI.dfdl.xsd(EDI-inspired,+field separator,'segment terminator), test data files (SimpleEDI-happy.txt,SimpleEDI-error.txt), TDML test suite (SimpleEDITests.tdmlwith parse, round-trip, and error cases), and Scala test runner (TestSimpleEDI.scala). All three tests pass against both IBM DFDL (ACE 12) and Daffodil.UPGRADE-NOTES.md: new document covering all 9 Daffodil API changes with before/after code snippets, the ACE 11 → ACE 12/13 jar name mapping table, and descriptions of all new files.Test plan
.\setup-ace-jars.ps1 -AceVersion 12— verify 11 jars copied tolib/.\setup-ace-jars.ps1 -AceVersion 13— verify same result from ACE 13 install.\setup-ace-jars.ps1 -AcePath "<custom path>"— verify custom path is acceptedsbt -java-home "C:\Program Files\IBM\ACE\12.0.12.17\common\java17" compile— clean buildsbt -java-home "C:\Program Files\IBM\ACE\12.0.12.17\common\java17" test— all 11 tests pass (TestIBMDFDLSamples ×2, TestCrossTestRig ×6, TestSimpleEDI ×3)🤖 Generated with Claude Code