Open
Conversation
Refactored TMWIL app code: Solves the group of "find endpoint" issues and the redundant query code block problem.
Branch 1 1. Query object refactor version 2. 2. Added additional datasets from FirstMap API.
Add files via upload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored TMWIL app code: Solves the group of "find endpoint" issues and the redundant query code block problem.
The main changes are the creation of separate JS files that house objects that I built to refactor the quesry code blocks. Also, there is more data being pulled in from the School District and Grade Two Feeder Patterns boundaries that were added.
The refactor suggests that the next steps may be to build our own database so that we may be able to perform more efficient queries.