Skip to content

Add choose your own magic command. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add choose your own magic command. #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff3c71f
Add choose your own magic command.
kindly May 24, 2021
e770003
add changelog
kindly May 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

### Added

- Way to define your own magic function.

## [0.5.0] - 2021-05-22

Expand Down
17 changes: 15 additions & 2 deletions noteql/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@

LOCAL_DB_MADE = False

REGISTERED_MAGICS = False


def get_engine(dburi):
if not dburi:
Expand Down Expand Up @@ -110,7 +112,8 @@ def __init__(
df_viewer=None,
df_viewer_kw=None,
datasette_url=None,
cell_magic_output=False
cell_magic_name=None,
cell_magic_output=False,
):
self.schema = schema
self.dburi = dburi
Expand Down Expand Up @@ -150,7 +153,17 @@ def __init__(
connection.execute("create schema if not exists {};".format(self.schema))

self.ipython = get_ipython()
self.ipython.register_magics(Noteql)

global REGISTERED_MAGICS

if not REGISTERED_MAGICS:
if cell_magic_name:
Noteql.magics["line"][cell_magic_name] = Noteql.magics["line"].pop("nql")
Noteql.magics["cell"][cell_magic_name] = Noteql.magics["cell"].pop("nql")

self.ipython.register_magics(Noteql)
REGISTERED_MAGICS = True

self.set()

def tables(self):
Expand Down