Skip to content

Save metadata about valid datasets to database #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 11, 2025
Merged

Save metadata about valid datasets to database #16

merged 3 commits into from
Feb 11, 2025

Conversation

tillywoodfield
Copy link
Contributor

@tillywoodfield tillywoodfield commented Feb 4, 2025 •
edited
Loading

Closes #3

@tillywoodfield tillywoodfield mentioned this pull request Feb 5, 2025
Merged
@tillywoodfield tillywoodfield requested a review from Bjwebb February 5, 2025 10:13
Base automatically changed from 4-registry to live February 6, 2025 11:02
Bjwebb
Bjwebb requested changes Feb 6, 2025
View reviewed changes
Copy link
Member

@Bjwebb Bjwebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the dataset itself isn't being saved to the db here. Is it possible to make that more explicit in the commit messages and the PR title?

@tillywoodfield tillywoodfield changed the title Save valid datasets to database Save metadata about valid datasets to database Feb 6, 2025
@tillywoodfield tillywoodfield requested a review from Bjwebb February 6, 2025 14:38
@tillywoodfield tillywoodfield merged commit e1256ae into live Feb 11, 2025
1 check passed
@tillywoodfield tillywoodfield deleted the 3-database branch February 11, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bjwebb Bjwebb Bjwebb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store metadata about valid files in a database
2 participants
@tillywoodfield @Bjwebb