Skip to content

Remove datasets that have been deleted from the registry #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 12, 2025
Merged

Remove datasets that have been deleted from the registry #20

merged 2 commits into from
Feb 12, 2025

Conversation

tillywoodfield
Copy link
Contributor

Depends on #19

Closes #18

@tillywoodfield tillywoodfield requested a review from Bjwebb February 5, 2025 10:21
@tillywoodfield tillywoodfield mentioned this pull request Feb 6, 2025
Merged
@tillywoodfield tillywoodfield force-pushed the 18-remove-deleted-datasets branch from 318b683 to 66c7867 Compare February 6, 2025 14:43
jarofgreen
jarofgreen approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@jarofgreen jarofgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could have a few safety checks to make sure a problem in start of script doesn't then let the delete function clear out the entire DB - eg

if len(registered_datasets) < 2: raise Exception("seems unlikely?")

Base automatically changed from 7-csv-xlsx to live February 11, 2025 12:04
@tillywoodfield tillywoodfield merged commit 7a963bd into live Feb 12, 2025
1 check passed
@tillywoodfield tillywoodfield deleted the 18-remove-deleted-datasets branch February 12, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarofgreen jarofgreen jarofgreen approved these changes

@Bjwebb Bjwebb Awaiting requested review from Bjwebb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up removed datasets at the beginning of each run
2 participants
@tillywoodfield @jarofgreen