Portals #34
Merged
Portals #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dividual data records This means we can get all the dataset fields datatig has, previously we could only get fields in list_fields in the datatig config
michaelwood
reviewed
Jul 17, 2025
| "country": value["fields"]["country"]["value"], | ||
| registered_datasets = {} | ||
| for key, value in json_data["records"].items(): | ||
| r_data = requests.get(value["api_url"]) |
There was a problem hiding this comment.
I'm not sure how big json_data["records"] is but that could be a very large number of requests all at once? Has needing some kind of control on that been considered?
There was a problem hiding this comment.
It's only ~10 records and isn't expected to grow fast, and we have control over the API.
If it gets bigger the thing to do is look into methods where we can get all the data with one API call - currently the API does allow that (there's a sqlite with all the data in it) but it would be more changes, and this will do for now.
michaelwood
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.