Skip to content

Reworked blocking i2c slave interface #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidv1992 wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Reworked blocking i2c slave interface #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
423474a
Reworked blocking i2c slave interface
davidv1992 Apr 11, 2025
428acc2
Reworked async i2c slave interface to match blocking one.
davidv1992 Apr 24, 2025
0d8dd98
Ensure a deselect is still triggered on dropped i2c slave reads.
davidv1992 Apr 24, 2025
67149de
Split i2c listen functions in preparations for implement auto(n)ack.
davidv1992 Apr 24, 2025
4f696d5
Implemented support for automatic address acknowledgement.
davidv1992 Apr 25, 2025
a4399e4
Small cleanup work around i2c slave driver.
davidv1992 May 7, 2025
500700d
Fixed i2c slave slvctl register handling.
davidv1992 May 8, 2025
8cfc384
Added extensive testing for async i2c slave interface.
davidv1992 May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions examples/rt685s-evk/src/bin/i2c-loopback-async-10bit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
use defmt::info;
use embassy_executor::Spawner;
use embassy_imxrt::i2c::master::I2cMaster;
use embassy_imxrt::i2c::slave::{Address, Command, I2cSlave, Response};
use embassy_imxrt::i2c::slave::{Address, AsyncI2cSlave, ReadResult, Transaction, WriteResult};
use embassy_imxrt::i2c::{self, Async};
use embassy_imxrt::{bind_interrupts, peripherals};
use embedded_hal_async::i2c::I2c;
Expand Down Expand Up @@ -32,7 +32,7 @@ fn generate_buffer<const SIZE: usize>() -> [u8; SIZE] {
}

#[embassy_executor::task]
async fn slave_service(mut slave: I2cSlave<'static, Async>) {
async fn slave_service(mut slave: AsyncI2cSlave<'static>) {
loop {
// Buffer containing data read by the master
let t_buf: [u8; SLAVE_BUFLEN] = generate_buffer();
Expand All @@ -43,26 +43,29 @@ async fn slave_service(mut slave: I2cSlave<'static, Async>) {
let expected_buf: [u8; SLAVE_BUFLEN] = generate_buffer();

match slave.listen().await.unwrap() {
Command::Probe => {
Transaction::Deselect => {
info!("Probe, nothing to do");
}
Command::Read => {
Transaction::Read { mut handler, .. } => {
info!("Read");
loop {
match slave.respond_to_read(&t_buf).await.unwrap() {
Response::Complete(n) => {
match handler.handle_part(&t_buf).await.unwrap() {
ReadResult::Complete(n) => {
info!("Response complete read with {} bytes", n);
break;
}
Response::Pending(n) => info!("Response to read got {} bytes, more bytes to fill", n),
ReadResult::Partial(next_handler) => {
handler = next_handler;
info!("Response to read got {} bytes, more bytes to fill", t_buf.len())
}
}
}
}
Command::Write => {
Transaction::Write { mut handler, .. } => {
info!("Write");
loop {
match slave.respond_to_write(&mut r_buf).await.unwrap() {
Response::Complete(n) => {
match handler.handle_part(&mut r_buf).await.unwrap() {
WriteResult::Complete(n) => {
info!("Response complete write with {} bytes", n);
info!("i2cm write data: {:x}", r_buf[0..n]);

Expand All @@ -71,7 +74,10 @@ async fn slave_service(mut slave: I2cSlave<'static, Async>) {
assert!(r_buf[0..n] == expected_buf[0..n]);
break;
}
Response::Pending(n) => info!("Response to write got {} bytes, more bytes pending", n),
WriteResult::Partial(next_handler) => {
handler = next_handler;
info!("Response to write got {} bytes, more bytes pending", r_buf.len())
}
}
}
}
Expand Down Expand Up @@ -135,7 +141,7 @@ async fn main(spawner: Spawner) {
info!("i2c loopback example");
let p = embassy_imxrt::init(Default::default());

let slave = I2cSlave::new_async(p.FLEXCOMM2, p.PIO0_18, p.PIO0_17, Irqs, SLAVE_ADDR.unwrap(), p.DMA0_CH4).unwrap();
let slave = AsyncI2cSlave::new(p.FLEXCOMM2, p.PIO0_18, p.PIO0_17, Irqs, SLAVE_ADDR.unwrap(), p.DMA0_CH4).unwrap();

let master = I2cMaster::new_async(p.FLEXCOMM4, p.PIO0_29, p.PIO0_30, Irqs, Default::default(), p.DMA0_CH9).unwrap();

Expand Down
Loading