Fixed regression in main related to async i2c slave after enabling checks for unwrap #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipebalbi
approved these changes
Dec 15, 2025
kurtjd
approved these changes
Dec 15, 2025
Contributor
kurtjd
left a comment
kurtjd
left a comment
There was a problem hiding this comment.
Seems to be duplicate effort from this pr: https://github.com/OpenDevicePartnership/embassy-imxrt/pull/518/files#diff-a91f3f50016712dd356cf269090873cc0102257292f5732fc6ad1fcdfe83d789R260
Though since this will fix broken CI I think it's worth merging now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging main into #507 CI failed on a remaining
unwrapin the codebase.