Fix incorrect flexspi error handling#537
Merged
kurtjd merged 1 commit intoOpenDevicePartnership:mainfrom Jan 6, 2026
Merged
Conversation
ayodejiige
approved these changes
Jan 6, 2026
tullom
previously approved these changes
Jan 6, 2026
Contributor
tullom
left a comment
tullom
left a comment
There was a problem hiding this comment.
Looks good, just one nonblocking comment
tullom
approved these changes
Jan 6, 2026
jerrysxie
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had mistakenly thought
program_lutalways requires aSome(data_bytes)but looking at it again it only needsSome(data_bytes)in the case ofSome(transfertype).Because of my mistaken assumption, I was returning an error early from
send_commandwhen I shouldn't have, so this PR fixes it so we don't do that.