Update crates to rust 1.83 #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertZ2011
requested review from
JamesHuard,
akshat2112,
felipebalbi,
jeffglaum,
jerrysxie and
madeleyneVaca
and removed request for
akshat2112 and
jerrysxie
JamesHuard
approved these changes
Dec 20, 2024
felipebalbi
requested changes
Dec 20, 2024
Contributor
felipebalbi
left a comment
felipebalbi
left a comment
There was a problem hiding this comment.
You should update .github/workflows/check.yml too. Specifically, msrv job.
Upstream embassy now requires 1.83
RobertZ2011
force-pushed
the
183-update
branch
from
5965648 to
f9e1bf9
Compare
Contributor
Author
Done. Thanks for the catch. |
felipebalbi
approved these changes
Dec 20, 2024
madeleyneVaca
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream embassy now requires 1.83