hid-service: use HID descriptor registers #666
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 4, 2026 02:59
…ded-services into personal/razbenhemo/hid_device_handle_cmds
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the HID-over-I2C device handling to use register addresses provided by the HID descriptor instead of relying on static/default values, improving device compatibility and correctness.
Key changes:
- Input reports are now read using
write_read()with the descriptor'sw_input_register - Command and data register addresses are sourced from the HID descriptor with fallback to configured defaults
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added 2 commits
January 4, 2026 04:03
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RobertZ2011
requested changes
Jan 5, 2026
RobertZ2011
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update
hid-serviceI2C device handling to use register addresses provided by the HID descriptor, including input report reads and command/data register selection.Why
Ensure HID-over-I2C transactions use the correct device-specific register map (from the HID descriptor) instead of relying on static/default register values, improving compatibility and correctness across devices.
How
hid-service/src/i2c/device.rsto:write_read()usingw_input_registerw_command_register/w_data_registerfrom the HID descriptor when encoding commands, with fallback to configured defaults on descriptor read failure