Skip to content

[RFC] Zerocopy for serializing/deserializing ODP service messages #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kurtjd wants to merge 1 commit into
base: v0.2.0
Choose a base branch
from
Draft

[RFC] Zerocopy for serializing/deserializing ODP service messages #678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions examples/rt633/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions examples/std/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

55 changes: 30 additions & 25 deletions examples/std/src/bin/thermal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ use static_cell::StaticCell;
use std::sync::atomic::AtomicUsize;
use std::sync::atomic::Ordering;
use thermal_service as ts;
use thermal_service_messages::ThermalRequest;
use thermal_service_messages::{
ThermalGetTmpRequest, ThermalGetVarRequest, ThermalRequest, ThermalSetThrsRequest, ThermalSetVarRequest,
};
use ts::mptf;

// Mock host service
Expand All @@ -21,7 +23,7 @@ mod host {
use embedded_services::comms::{self, Endpoint, EndpointID, External, MailboxDelegate};
use log::{info, warn};
use thermal_service as ts;
use thermal_service_messages::{ThermalResponse, ThermalResult};
use thermal_service_messages::{ThermalGetTmpResponse, ThermalGetVarResponse, ThermalResponse, ThermalResult};
use ts::mptf;

pub struct Host {
Expand All @@ -39,10 +41,10 @@ mod host {

fn handle_response(&self, response: ThermalResponse) {
match response {
ThermalResponse::ThermalGetTmpResponse { temperature } => {
ThermalResponse::ThermalGetTmpResponse(ThermalGetTmpResponse { temperature }) => {
info!("Host received temperature: {} °C", ts::utils::dk_to_c(temperature))
}
ThermalResponse::ThermalGetVarResponse { val } => {
ThermalResponse::ThermalGetVarResponse(ThermalGetVarResponse { val }) => {
info!("Host received fan RPM: {val}")
}
_ => info!("Received MPTF response: {response:?}"),
Expand Down Expand Up @@ -219,12 +221,12 @@ async fn host() {
host.tp
.send(
thermal_id,
&ThermalRequest::ThermalSetThrsRequest {
&ThermalRequest::ThermalSetThrsRequest(ThermalSetThrsRequest {
instance_id: 0,
timeout: 0,
low: 0,
high: 3131,
},
timeout: 0.into(),
low: 0.into(),
high: 3131.into(),
}),
)
.await
.unwrap();
Expand All @@ -234,12 +236,12 @@ async fn host() {
host.tp
.send(
thermal_id,
&ThermalRequest::ThermalSetVarRequest {
&ThermalRequest::ThermalSetVarRequest(ThermalSetVarRequest {
instance_id: 0,
len: 4,
len: 4.into(),
var_uuid: mptf::uuid_standard::FAN_ON_TEMP,
set_var: 3131,
},
set_var: 3131.into(),
}),
)
.await
.unwrap();
Expand All @@ -249,12 +251,12 @@ async fn host() {
host.tp
.send(
thermal_id,
&ThermalRequest::ThermalSetVarRequest {
&ThermalRequest::ThermalSetVarRequest(ThermalSetVarRequest {
instance_id: 0,
len: 4,
len: 4.into(),
var_uuid: mptf::uuid_standard::FAN_RAMP_TEMP,
set_var: 3231,
},
set_var: 3231.into(),
}),
)
.await
.unwrap();
Expand All @@ -264,12 +266,12 @@ async fn host() {
host.tp
.send(
thermal_id,
&ThermalRequest::ThermalSetVarRequest {
&ThermalRequest::ThermalSetVarRequest(ThermalSetVarRequest {
instance_id: 0,
len: 4,
len: 4.into(),
var_uuid: mptf::uuid_standard::FAN_MAX_TEMP,
set_var: 3531,
},
set_var: 3531.into(),
}),
)
.await
.unwrap();
Expand All @@ -281,7 +283,10 @@ async fn host() {

info!("Host requesting temperature in response to threshold alert");
host.tp
.send(thermal_id, &ThermalRequest::ThermalGetTmpRequest { instance_id: 0 })
.send(
thermal_id,
&ThermalRequest::ThermalGetTmpRequest(ThermalGetTmpRequest { instance_id: 0 }),
)
.await
.unwrap();

Expand All @@ -292,11 +297,11 @@ async fn host() {
host.tp
.send(
thermal_id,
&ThermalRequest::ThermalGetVarRequest {
&ThermalRequest::ThermalGetVarRequest(ThermalGetVarRequest {
instance_id: 0,
len: 4,
len: 4.into(),
var_uuid: mptf::uuid_standard::FAN_CURRENT_RPM,
},
}),
)
.await
.unwrap();
Expand Down
1 change: 1 addition & 0 deletions thermal-service-messages/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ defmt = { workspace = true, optional = true }
embedded-services.workspace = true
num_enum.workspace = true
uuid.workspace = true
zerocopy.workspace = true

[lints]
workspace = true
Expand Down
Loading