patina_internal_collections: Prevent out-of-bounds access in resize() #1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Javagedes
approved these changes
Jan 14, 2026
os-d
approved these changes
Jan 14, 2026
Add bounds checking before accessing buffer[idx] in Storage::resize(). When resizing to a buffer with no free space (idx >= buffer.len()), set available to null instead of attempting to access out-of-bounds memory. Signed-off-by: Michael Kubacki <[email protected]>
makubacki
force-pushed
the
patina_internal_coll_fix_out_of_bound_access
branch
from
9ce272e to
7f7a058
Compare
Contributor
|
Good catch - there are a couple more out-of-bounds checks needed - I opened a new PR #1247 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add bounds checking before accessing buffer[idx] in Storage::resize().
When resizing to a buffer with no free space (idx >= buffer.len()), set available to null instead of attempting to access out-of-bounds memory.
How This Was Tested
cargo make all)Integration Instructions