Skip to content

Conversation

@ike709
Copy link
Collaborator

@ike709 ike709 commented Oct 26, 2024

The upward path search operator didn't resolve paths correctly specifically when there was nothing on the lefthand side of the operator.

This is because:

/obj/foo
/obj/bar
    var/meep = .foo

would resolve to /obj/.foo instead of /obj/foo

Now we strip the search operator out of the path string if there's nothing on the lefthand side, so it can be combined into the correct path.

The other upward search unit tests confirm that this doesn't break anything when there is a lefthand side. I also confirmed TG didn't explode.

Fixes #617

@boring-cyborg boring-cyborg bot added the Compiler Involves the OpenDream compiler label Oct 26, 2024
@ike709 ike709 requested a review from wixoaGit October 26, 2024 21:08
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ike709
Copy link
Collaborator Author

ike709 commented Nov 12, 2024

Fixed on master and unit test added in #2087

@ike709 ike709 closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compiler Involves the OpenDream compiler Merge Conflict size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Path operators don't work without a left-hand side

1 participant